Add dimensions option to CLI validate-scenarios #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #404
Adds a
--dimensionsoption to thevalidate-scenarioscommand and sets this variable as described here.The additional test for implicit dimension setting is separate from original tests to preserve slightly cleaner code because of a technical detail on how the
dimensionsvariable is set by the test CLI runner ((None,)/('',)instead of()).Test harmonisation between
validate-projectandvalidate-scenarioswill come in upcoming PR to ensure the tests: 1) check exit code, 2) check type of exception, 3) check error message.Setting
dimensionsaccording tonomenclature.yamlis done in the CLI function(s) to overrideDataStructureDefinition's standard order of explicit dimensions ->nomenclature.yaml-> default to["region", "variable"]. In this way, ifnomenclature.yamldoes not setdimensions(=None), it checksdefinitionssubfolders (as previously implemented and now updated forvalidate-project)