Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Lea Seep <74967328+LeaSeep@users.noreply.github.com>
  • Loading branch information
PaulJonasJost and LeaSeep authored Dec 11, 2023
1 parent fa45576 commit d98116c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion program/shinyApp/R/significance_analysis/ui.R
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ significance_analysis_sidebar_ui<- function(ns){
significance_analysis_main_ui <- function(ns){
mainPanel(
id = "main_significance_analysis",
# informative text, whether ana lysis was done or not
# informative text, whether analysis was done or not
htmlOutput(outputId = ns("significance_analysis_info"), container = pre),
tabsetPanel(
id = ns("significance_analysis_results"),
Expand Down
6 changes: 4 additions & 2 deletions program/shinyApp/R/significance_analysis/util.R
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ create_new_tab_manual <- function(title, targetPanel, result, contrast, alpha, n
fixedColumns = TRUE,
autoWidth = TRUE,
ordering = TRUE,
order = list(list(4, 'asc'), list(5, 'asc')), # 2=padj, 1=pvalue
order = list(list(4, 'asc'), list(5, 'asc')), # 4=padj, 5=pvalue
dom = 'Bfrtip',
lengthMenu = c(10, 25, 50, 100, -1),
buttons = c('pageLength', 'copy', 'csv', 'excel')
Expand Down Expand Up @@ -297,8 +297,9 @@ create_new_tab_manual <- function(title, targetPanel, result, contrast, alpha, n
) +
scale_color_manual(values=colorScheme2, name="") +
xlab("Log FoldChange") +
ylab("-log10(p-value)") +
ylab("-log10(p_adj-value)") +
theme(legend.position = "none") +
theme_bw()+
ggtitle(label="Corrected p-Values")
output[[ns(paste(contrast[1], contrast[2], "Volcano", sep = "_"))]] <- renderPlotly({ggplotly(
sig_ana_reactive$VolcanoPlot,
Expand All @@ -323,6 +324,7 @@ create_new_tab_manual <- function(title, targetPanel, result, contrast, alpha, n
scale_color_manual(values=colorScheme2, name="") +
xlab("Log FoldChange") +
ylab("-log10(p-value)") +
theme_bw()+
ggtitle(label="Uncorrected p-Values")
output[[ns(paste(contrast[1], contrast[2], "Volcano_praw", sep = "_"))]] <- renderPlotly({ggplotly(
sig_ana_reactive$VolcanoPlot_raw,
Expand Down

0 comments on commit d98116c

Please sign in to comment.