Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add waiters show/hide to all R Code Download #351

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

LeaSeep
Copy link
Collaborator

@LeaSeep LeaSeep commented Oct 29, 2024

address #350
For Future ideas:

  • enhance speed

@LeaSeep LeaSeep requested a review from PaulJonasJost October 29, 2024 13:03
Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetRCode not working for:

  • Preprocess
  • sample core
  • sig ana
  • Volcano (different error, just downloads the page?)
  • SingleGeneVis
  • Enrichment

Error message is object 'waiter' not found' perhaps solved by assigning it as a reactive value. Other wise needs reinitialisation

…ter$new}) and then waiter()$show - did not work
@LeaSeep LeaSeep requested a review from PaulJonasJost October 30, 2024 09:52
Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, tested for preprocessing and volcano 👍🏼

@LeaSeep LeaSeep merged commit d55da9a into develop Oct 30, 2024
1 check passed
@PaulJonasJost PaulJonasJost deleted the show_codeGeneration_process branch November 13, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants