Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily exclude sphinx 8.2.0 to fix doctests #1572

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

blnicho
Copy link
Member

@blnicho blnicho commented Feb 20, 2025

Summary/Motivation:

Doctests started failing with the latest Sphinx release. We noticed similar issues in Pyomo that could be traced to Sphinx extensions that don't yet support Sphinx 8.2.0. This PR excludes this version of Sphinx for now to get IDAES tests passing again. I haven't identified which Sphinx extension is the underlying cause of the issue.

Changes proposed in this PR:

  • Exclude Sphinx version 8.2.0

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.86%. Comparing base (2182772) to head (4dd256e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1572      +/-   ##
==========================================
- Coverage   76.86%   76.86%   -0.01%     
==========================================
  Files         394      394              
  Lines       63233    63233              
  Branches    10355    10355              
==========================================
- Hits        48604    48601       -3     
- Misses      12184    12188       +4     
+ Partials     2445     2444       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blnicho blnicho added the CI:run-integration triggers_workflow: Integration label Feb 20, 2025
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Feb 20, 2025
@blnicho blnicho added the CI:run-integration triggers_workflow: Integration label Feb 20, 2025
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Feb 20, 2025
@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Feb 20, 2025
Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbianchi-lbl lbianchi-lbl merged commit ba3c5d4 into IDAES:main Feb 20, 2025
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants