Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General - Add icons to ACE actions #1380

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Timi007
Copy link
Contributor

@Timi007 Timi007 commented Feb 6, 2025

When merged this pull request will:

  • Add icons to ACE actions to radios
  • Cleanup code (use LLSTRING)

Example:
image

TODO

  • Add icons to self-interaction
  • Add icons to intercom
  • Add icons to shared radios
  • Add icons for intercom broadcast
  • Add icons for intercom accent

addons/ace_interact/README.md Outdated Show resolved Hide resolved
@Drofseh
Copy link
Contributor

Drofseh commented Feb 6, 2025

I'm not sure icons with letters should be used (L, R, PTT, etc) as they won't be translated if the user selects a non-English language,

@Timi007
Copy link
Contributor Author

Timi007 commented Feb 6, 2025

I'm not sure icons with letters should be used (L, R, PTT, etc) as they won't be translated if the user selects a non-English language,

I also am not sure how to depict those actions. I thought that L and R would be ok because most headphone makers also label it as such. In addition to that I added the sound direction. Would arrows be better or (double) chevrons? What about center, should it be left and right arrows?

Is a microphone with a number better suited for PTT?

@Drofseh
Copy link
Contributor

Drofseh commented Feb 6, 2025

I'm not sure icons with letters should be used (L, R, PTT, etc) as they won't be translated if the user selects a non-English language,

I also am not sure how to depict those actions. I thought that L and R would be ok because most headphone makers also label it as such. In addition to that I added the sound direction. Would arrows be better or (double) chevrons? What about center, should it be left and right arrows?

Is a microphone with a number better suited for PTT?

I think probably just the sound wave icons, (((, ))), ((( ))), are fine for L, R, and C
You could do waves and an arrow ((( <- but I'm not sure if it'd be better or not.

Mic icon by itself (no number) is probably fine for the PTT icons. The number is presumably always in the text right under the icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants