Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize disk names, add VERBOSE and PRINT_TEMPS #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Sanitize disk names, add VERBOSE and PRINT_TEMPS #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions fan_speed_control.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,15 @@ INCLUDE_DISK_TYPE_CACHE=1
INCLUDE_DISK_TYPE_FLASH=0
INCLUDE_DISK_TYPE_UNASSIGNED=1

# Set verbose mode
# Log size may increase significantly
# Usage is recommended only when debugging
VERBOSE="no"

# Print temperature readings
# Log size may increase in proportion to how many disks you have
PRINT_TEMPS="no"

EXCLUDE_DISK_BY_NAME=(
"cache_system"
"cache_system2"
Expand Down Expand Up @@ -82,6 +91,11 @@ while [[ "$#" -gt 0 ]]; do
shift
done

# Sanitize variable names
sanitize() {
local orig_name=$1
echo $orig_name | tr '-' '_'
}

# Function to check if a file exists
check_file_exists() {
Expand Down Expand Up @@ -175,7 +189,7 @@ include_disk_types[Unassigned]=$INCLUDE_DISK_TYPE_UNASSIGNED
declare -a disk_list_all
while IFS='= ' read var val; do
if [[ $var == \[*] ]]; then
disk_name=${var:2:-2}
disk_name=$(sanitize ${var:2:-2})
disk_list_all+=($disk_name)
eval declare -A ${disk_name}_data
elif [[ $val ]]; then
Expand All @@ -187,7 +201,7 @@ done < /var/local/emhttp/disks.ini
if [[ -f /usr/local/emhttp/state/devs.ini ]]; then
while IFS='= ' read var val; do
if [[ $var == \[*] ]]; then
disk_name=${var:2:-2}
disk_name=$(sanitize ${var:2:-2})
disk_list_all+=($disk_name)
eval declare -A ${disk_name}_data
eval ${disk_name}_data[type]="Unassigned"
Expand All @@ -203,12 +217,15 @@ for disk in "${disk_list_all[@]}"; do
disk_name=${disk}_data[name]
disk_type=${disk}_data[type]
disk_id=${disk}_data[id]
[[ $VERBOSE == "yes" ]] && echo "Found disk '${!disk_name}' of type '${!disk_type}'"
disk_type_filter=${include_disk_types[${!disk_type}]}

if [[ ! -z "${!disk_id}" ]] && \
[[ "${disk_type_filter}" -ne 0 ]] && \
[[ ! " ${EXCLUDE_DISK_BY_NAME[*]} " =~ " ${disk} " ]]; then
disk_list+=($disk)
else
[[ $VERBOSE == "yes" ]] && echo "Excluding disk '${!disk_name}'"
fi
done

Expand All @@ -223,14 +240,17 @@ for disk in "${disk_list[@]}"
do
# Check disk state
eval state_value=${disk}_data[spundown]
eval disk_name=${disk}_data[name]
if (( ${state_value} == 1 ))
then
state=spundown
disk_state[${disk}]=spundown
[[ $VERBOSE == "yes" || $PRINT_TEMPS == "yes" ]] && echo "Disk '${!disk_name}' is spun down"
else
state=spunup
disk_state[${disk}]=spunup
disk_active_num=$((disk_active_num+1))
[[ $VERBOSE == "yes" ]] && echo "Disk '${!disk_name}' is active"
fi

# Check disk temperature
Expand All @@ -240,6 +260,7 @@ do
if [[ "${!temp}" =~ ^[0-9]+$ ]]
then
disk_temp[${disk}]=${!temp}
[[ $VERBOSE == "yes" || $PRINT_TEMPS == "yes" ]] && echo "Temperature reading for '${!disk_name}': ${!temp}ºC"
if (( "${!temp}" > "$disk_max_temp_value" ))
then
disk_max_temp_value=${!temp}
Expand Down