Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send email bcc improvement #35

Merged
merged 8 commits into from
Sep 4, 2024
Merged

Send email bcc improvement #35

merged 8 commits into from
Sep 4, 2024

Conversation

sgeulette
Copy link
Member

No description provided.

@sgeulette sgeulette requested a review from gbastien August 28, 2024 19:54
@coveralls
Copy link

coveralls commented Aug 28, 2024

Coverage Status

coverage: 85.282% (+0.2%) from 85.087%
when pulling 95c3bac on send_email_bcc_improvement
into eb0c27e on master.

Copy link
Member

@gbastien gbastien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salut @sgeulette

en regardant en travers:

  • utilisation de iteritems(dict) pourrait être remplacé par dict.items?
  • peut-être ajouter un test avec le paramètre mbcc?
    Je vais aussi essayer de tester dans PloneMeeting comme on a presque la même fonction probablement çà peut être remplacé facilement...
    Gauthier

@sgeulette
Copy link
Member Author

Copy link
Member

@gbastien gbastien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgeulette sgeulette merged commit fa8f07b into master Sep 4, 2024
8 checks passed
@sgeulette sgeulette deleted the send_email_bcc_improvement branch September 4, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants