Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename nonstructural building damage #582

Merged
merged 4 commits into from
Jun 6, 2024
Merged

Rename nonstructural building damage #582

merged 4 commits into from
Jun 6, 2024

Conversation

ylyangtw
Copy link
Contributor

@ylyangtw ylyangtw commented Jun 5, 2024

No description provided.

@ylyangtw ylyangtw linked an issue Jun 5, 2024 that may be closed by this pull request
Rename nonstructural building damage #537
Closed
@navarroc
Copy link
Member

navarroc commented Jun 5, 2024 •
edited
Loading

Why did you rename the original folder? The original should stay the same path. Also, any reason not to include full name? It should be BuildingNonstructuralDamage for name and the path would be buildingnonstructuraldamage

@navarroc
Copy link
Member

navarroc commented Jun 5, 2024 •
edited
Loading

Why did you rename the original folder? The original should stay the same path. Also, any reason not to include full name? It should be BuildingNonstructuralDamage for name and the path would be buildingnonstructuraldamage

Oops, I saw that wrong. I thought you had renamed the original path but the original was abbreviated. But can we make the new one the full name instead of the abbreviated?

@ylyangtw
Copy link
Contributor Author

ylyangtw commented Jun 5, 2024

Why did you rename the original folder? The original should stay the same path. Also, any reason not to include full name? It should be BuildingNonstructuralDamage for name and the path would be buildingnonstructuraldamage

Oops, I saw that wrong. I thought you had renamed the original path but the original was abbreviated. But can we make the new one the full name instead of the abbreviated?

Yeah I wasn't sure what's the "full name" so I just referenced the old name. Do you mean buildingnonstructuraldamage?

@longshuicy longshuicy merged commit ba6e2e2 into develop Jun 6, 2024
7 checks passed
@longshuicy longshuicy deleted the Rename-nonstructural-building-damage branch June 6, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longshuicy longshuicy longshuicy approved these changes

@ywkim312 ywkim312 ywkim312 approved these changes

@navarroc navarroc Awaiting requested review from navarroc

@Rashmil-1999 Rashmil-1999 Awaiting requested review from Rashmil-1999

Assignees

@ylyangtw ylyangtw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename nonstructural building damage
4 participants
@ylyangtw @navarroc @ywkim312 @longshuicy