Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename building damage to building structural damage #583

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Rename building damage to building structural damage #583

merged 2 commits into from
Jun 6, 2024

Conversation

ylyangtw
Copy link
Contributor

@ylyangtw ylyangtw commented Jun 5, 2024

No description provided.

@ylyangtw ylyangtw linked an issue Jun 5, 2024 that may be closed by this pull request
Rename building damage to building structural damage #561
Closed
longshuicy
longshuicy approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and run well. Compared some of the results and they are identical. Approved.

ywkim312
ywkim312 reviewed Jun 6, 2024
View reviewed changes
docs/source/modules.rst Outdated Show resolved Hide resolved
ywkim312
ywkim312 approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@ywkim312 ywkim312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked well except my comment. I approve but please address my comment.

@longshuicy longshuicy merged commit 07c4dba into develop Jun 6, 2024
7 checks passed
@longshuicy longshuicy deleted the Rename-building-damage-to-building-structural-damage branch June 6, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywkim312 ywkim312 ywkim312 approved these changes

@longshuicy longshuicy longshuicy approved these changes

@navarroc navarroc Awaiting requested review from navarroc

@Rashmil-1999 Rashmil-1999 Awaiting requested review from Rashmil-1999

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename building damage to building structural damage
3 participants
@ylyangtw @ywkim312 @longshuicy