Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fixing sonarqube issues in Pattern.java #6172

Merged

Conversation

rishivijayv
Copy link
Contributor

#2228

This fixes a few sonarqube warnings in the file Pattern.java that were pointed out by the SonarQube for IDE Plugin. Namely, the issues were:

  • java:S1905 (Redundant casts should not be used)
  • java:S1612 (Lambdas should be replaced with method references)
  • java:S1602 (when a lambda expression uses block notation while expression notation could be used)

I believe removing the explicit cast to Map<...,...> also seems to get rid of one of the warnings during compile time, so...yay! ?

@rishivijayv
Copy link
Contributor Author

@I-Al-Istannen @algomaster99 would appreciate your review of this whenever you guys get the chance! :)

@monperrus monperrus merged commit 092d610 into INRIA:master Feb 6, 2025
13 checks passed
@monperrus
Copy link
Collaborator

thanks @rishivijayv

@rishivijayv rishivijayv deleted the refactor/quick-sonar-updates-pattern branch February 6, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants