TD - 3284 Nowrap Typography truncted tooltip #1032
Conversation
src/Card/DetailCard/DetailCard.tsx
Outdated
There was a problem hiding this comment.
Why the changes here? Typescript should already be able to infer the theme type?
There was a problem hiding this comment.
In this case we were getting an explicit TypeScript error about theme having an implicit 'any' type. So I added it to resolve the TypeScript error we were seeing. Let me know if you'd prefer a different approach to handle this.
There was a problem hiding this comment.
So if the types are broken, I suggest that we investigate why the types might be broken rather than trying to override the types in the places that they show that they are broken.
I've done some digging and I think the issue relates to that discussed in this blog where we are trying to use forwardRef with a generic component.
I've gone ahead and tried to fix this for you. I suggest that you test this in VIRTO.
|
I'm confused why this branch no targets RUI v11 and has that code merged in. I was expecting this to go in a v10.4.1 release. |
* Manually bring in all changes from #1032 * 10.4.1-1 * 10.4.1-2
* bug/TD-3284 nowrap typography truncation ellipsis color issue * updated request changes by approaching computed style * Upadted TruncatedTooltip.tsx * Updated changes requested * updated comment line for adjacent code * Update stories to show how to correctly use Link with this component * Undo change of sx order * Deleted NoWrapTypography * Replaced NoWrapTypography with TruncatedTooltip * Update LabeSelector.jsx * Replace NoWrapTypography with TruncatedTooltip * updated changes requested * Updated changes requested * Restore NoWrapTypography * Undo change to grid import * TD-3355 - Fixes Clear button on Variant select when deselecting (#1033) * Fixes Clear button on Variant select when deselecting * Add test to test clear button * Bumped the test coverage for this file up slightly * TD-3284 Truncated Tooltip (#1034) * Manually bring in all changes from #1032 * 10.4.1-1 * 10.4.1-2 --------- Co-authored-by: ShushN <sushmitha.a@ipg-automotive.com> Co-authored-by: Matthew Corner <matt.corner@ipg-automotive.com> Co-authored-by: stevenmcsorleyipg <steven.mcsorley@ipg-automotive.uk>
Closes/Contributes TD-3284
Changes
A brief description of what this pull request solves / introduces.
Maybe a short description of what is not included and will come in future work where appropriate.
Dependencies
NA
UI/UX
NA
Testing notes
NA
Author checklist
Before I request a review:
I have tested the changes in Docker / a deploy-preview.I have included appropriate tests.I have populated the deploy-preview with relevant test data.I have tagged a UI/UX designer for review if this PR includes UI/UX changes.