TD-3355 - Fixes Clear button on Variant select when deselecting #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -223,7 +223,10 @@ function VehicleSelector({ | |||
| } | |||
| }} | |||
| size={size} | |||
| value={selectedVariants} | |||
| // if array is empty set to null to avoid rendereing the clear button | |||
There was a problem hiding this comment.
spelling and punctuation suggestion
Suggested change
| // if array is empty set to null to avoid rendereing the clear button | |
| // if array is empty, set value to null to avoid rendering the clear button |
AronPetrauskas
requested changes
Jan 29, 2025
There was a problem hiding this comment.
A nit picky comment suggestion to fix a comment. Other than that the functionality is good.
I think you'll need to write some more tests to increase the line coverage of Vehicle Selector. I have received this comment from Matt on a virto-utils PR of mine. I assume the same logic applies to RUI
stevenmcsorleyipg
deleted the
TD-3355/Clear-Button-Remains-Visible-in-Variant-Autocomplete-After-Clearing-Selection-RUI
branch
Merged
lukemojo
added a commit
that referenced
this pull request
Jan 31, 2025
* bug/TD-3284 nowrap typography truncation ellipsis color issue * updated request changes by approaching computed style * Upadted TruncatedTooltip.tsx * Updated changes requested * updated comment line for adjacent code * Update stories to show how to correctly use Link with this component * Undo change of sx order * Deleted NoWrapTypography * Replaced NoWrapTypography with TruncatedTooltip * Update LabeSelector.jsx * Replace NoWrapTypography with TruncatedTooltip * updated changes requested * Updated changes requested * Restore NoWrapTypography * Undo change to grid import * TD-3355 - Fixes Clear button on Variant select when deselecting (#1033) * Fixes Clear button on Variant select when deselecting * Add test to test clear button * Bumped the test coverage for this file up slightly * TD-3284 Truncated Tooltip (#1034) * Manually bring in all changes from #1032 * 10.4.1-1 * 10.4.1-2 --------- Co-authored-by: ShushN <sushmitha.a@ipg-automotive.com> Co-authored-by: Matthew Corner <matt.corner@ipg-automotive.com> Co-authored-by: stevenmcsorleyipg <steven.mcsorley@ipg-automotive.uk>
stevenmcsorleyipg
restored the
TD-3355/Clear-Button-Remains-Visible-in-Variant-Autocomplete-After-Clearing-Selection-RUI
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close TD-3355
Changes
Removes the X close button when the variant select is cleared, it was only happening on the variant select
Adding UX @Sowbhagya-ipg
Dependencies
n/a
UI/UX
before
After
Testing notes
Author checklist
Before I request a review:
- [ ] I have tested the changes in Docker / a deploy-preview.- [ ] I have included appropriate tests.- [ ] I have populated the deploy-preview with relevant test data.