-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TD-2308 Add support to show helper icon and tooltip #770
Merged
m4manjesh
merged 13 commits into
main
from
ehancemewnt/td-2308-autocomplete-support-tooltip
Nov 16, 2023
Merged
TD-2308 Add support to show helper icon and tooltip #770
m4manjesh
merged 13 commits into
main
from
ehancemewnt/td-2308-autocomplete-support-tooltip
Nov 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4manjesh
changed the base branch from
main
to
enhancement/autocomplete-is-option-equal-to-value
November 14, 2023 10:52
Checked it. LGTM |
mattcorner
requested changes
Nov 14, 2023
6 tasks
Base automatically changed from
enhancement/autocomplete-is-option-equal-to-value
to
main
November 15, 2023 09:39
…tps://github.com/IPG-Automotive-UK/react-ui into ehancemewnt/td-2308-autocomplete-support-tooltip
mattcorner
approved these changes
Nov 16, 2023
m4manjesh
deleted the
ehancemewnt/td-2308-autocomplete-support-tooltip
branch
November 16, 2023 09:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to TD-2308
This is the first PR for this ticket to update the Autocomplete component to add support to show a helper icon for the tooltip.
Changes
KeyValueOption
type updated to support optionaltooltip
field.OptionWithTooltip
component to show helper icon with tooltipisOptionEqualToValue
check logic to avoid warning in key-value options.Dependencies
UI/UX
Figma: https://www.figma.com/proto/s2NuBwBayu8144EGjBCi5d/VIRTO.DATA?node-id=3478-40400&scaling=min-zoom&page-id=281%3A22633&starting-point-node-id=4367%3A27791
Already demoed to @Sowbhagya-ipg
Testing notes
Author checklist before assigning a reviewer
Branch has been run in docker.