Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TD-2308 Add support to show helper icon and tooltip #770

Merged
merged 13 commits into from
Nov 16, 2023

Conversation

m4manjesh
Copy link
Contributor

@m4manjesh m4manjesh commented Nov 14, 2023

Contributes to TD-2308

This is the first PR for this ticket to update the Autocomplete component to add support to show a helper icon for the tooltip.

Changes

  • KeyValueOption type updated to support optional tooltip field.
  • New OptionWithTooltip component to show helper icon with tooltip
  • New "Key Value Options with Tooltip" story added
  • New tests added to check the helper icon and the tooltip is shown if the object contain tooltip fields
  • Updated the isOptionEqualToValue check logic to avoid warning in key-value options.

Dependencies

UI/UX

Figma: https://www.figma.com/proto/s2NuBwBayu8144EGjBCi5d/VIRTO.DATA?node-id=3478-40400&scaling=min-zoom&page-id=281%3A22633&starting-point-node-id=4367%3A27791

Screenshot (262)

Already demoed to @Sowbhagya-ipg

Testing notes

  • New "Key Value Options with Tooltip" should work as in Figma
  • All other stories should work fine as before and should not show helper icon

Author checklist before assigning a reviewer

  • Reviewed my own code-diff.
  • Branch has been run in docker.
  • PR assigned to me or an appropriate delegate.
  • Relevant labels added to the PR.
  • Appropriate tests have been added.
  • Lint and test workflows pass.

@m4manjesh m4manjesh added the enhancement New feature or request label Nov 14, 2023
@m4manjesh m4manjesh self-assigned this Nov 14, 2023
@m4manjesh m4manjesh changed the base branch from main to enhancement/autocomplete-is-option-equal-to-value November 14, 2023 10:52
@Sowbhagya-ipg
Copy link

Checked it. LGTM

@m4manjesh m4manjesh requested a review from mattcorner November 14, 2023 14:45
src/Autocomplete/Autocomplete.tsx Outdated Show resolved Hide resolved
src/Autocomplete/Autocomplete.tsx Outdated Show resolved Hide resolved
src/Autocomplete/Autocomplete.stories.tsx Outdated Show resolved Hide resolved
Base automatically changed from enhancement/autocomplete-is-option-equal-to-value to main November 15, 2023 09:39
@m4manjesh m4manjesh requested a review from mattcorner November 15, 2023 14:54
@m4manjesh m4manjesh merged commit 5d1a7d9 into main Nov 16, 2023
@m4manjesh m4manjesh deleted the ehancemewnt/td-2308-autocomplete-support-tooltip branch November 16, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants