Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing dependency install from postinstall #801

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Removing dependency install from postinstall #801

merged 4 commits into from
Dec 14, 2023

Conversation

VictorCLLucas
Copy link
Contributor

@VictorCLLucas VictorCLLucas commented Dec 7, 2023 •
edited
Loading

Changes

This change is to attempt to reduce the build times of VIRTO apps.

  • renamed the postinstall script so that it doesn't download these dependencies every time npm run install is ran
  • called the new script test-deps in npm run test:playwright so it only runs when running the tests

Testing notes

Author checklist before assigning a reviewer

  • Reviewed my own code-diff.
  • Branch has been run in docker.
  • PR assigned to me or an appropriate delegate.
  • Relevant labels added to the PR.
  • Appropriate tests have been added.
  • Lint and test workflows pass.

@VictorCLLucas VictorCLLucas added enhancement New feature or request dependencies Pull requests that update a dependency file labels Dec 7, 2023
@VictorCLLucas VictorCLLucas self-assigned this Dec 7, 2023
@VictorCLLucas VictorCLLucas changed the title renaming dependency install from postinstall Removing dependency install from postinstall Dec 13, 2023
@m4manjesh m4manjesh self-requested a review December 14, 2023 12:12
m4manjesh
m4manjesh approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@m4manjesh m4manjesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Playwright not called npm run install to install browsers

@VictorCLLucas VictorCLLucas merged commit d82b40b into main Dec 14, 2023
3 checks passed
@VictorCLLucas VictorCLLucas deleted the enhancement/reducing-build-time branch December 14, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4manjesh m4manjesh m4manjesh approved these changes

Assignees

@VictorCLLucas VictorCLLucas

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VictorCLLucas @m4manjesh