Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove type=module #816

Merged
merged 4 commits into from
Feb 19, 2024
Merged

Remove type=module #816

merged 4 commits into from
Feb 19, 2024

Conversation

mattcorner
Copy link
Contributor

Changes

As part of #810 I updated the package.json to have type: "module". Unfortunately this seems to break react-ui when it is consumed in our Remix apps.

I suspect its because we are using a deprecated @mui/material API for dark scrollbars (https://mui.com/material-ui/react-css-baseline/#scrollbars) but I'd like to investigate further. This PR is a hotfix to get main in a releasable state again.

We can accept that vitest will show a warning for the time being. This is just a warning and has no effect currently.
image

While here, I also updated storybook to remove the 4 vulnerabilities on this repository.

Testing notes

I release 6.1.1-2 prerelease to test this in VIRTO apps. You could install it in an app locally to ensure that it works correctly.

Author checklist before assigning a reviewer

  • Reviewed my own code-diff.
  • PR assigned to me or an appropriate delegate.
  • Relevant labels added to the PR.
  • Appropriate tests have been added.
  • Lint and test workflows pass.

@mattcorner mattcorner added the bug Something isn't working label Feb 19, 2024
@mattcorner mattcorner self-assigned this Feb 19, 2024
@mattcorner mattcorner changed the title Bug/type module Remove type=module Feb 19, 2024
Copy link
Contributor

@syedsalehinipg syedsalehinipg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on staging branch, error no longer showing.

@mattcorner mattcorner merged commit 9534a96 into main Feb 19, 2024
3 checks passed
@mattcorner mattcorner deleted the bug/type-module branch February 19, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants