NoWrapTypography sx prop does not work #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It breaks the teardown of the storybook server
mattcorner
changed the title
Skoob1905
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes the with the sx property which was not being applied to the component correctly.
It also solves some usability issues with playwright tests e.g. if a test is force exited and
pm2does not correctly teardown storybook, then subsequent test runs will work where they errored before.Dependencies
N/A
UI/UX
N/A
Testing notes
sxprop in storybook and it applies correctly. A vitest test has been added to confirm this,Author checklist before assigning a reviewer
Branch has been run in docker.