Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a Selector Button #834

Merged
merged 5 commits into from
Mar 22, 2024
Merged

Create a Selector Button #834

merged 5 commits into from
Mar 22, 2024

Conversation

Skoob1905
Copy link
Contributor

@Skoob1905 Skoob1905 commented Mar 21, 2024 •
edited
Loading

Changes

  • Selector Button has been created to be used by VIRTO.DATA and VIRTO.SCENE

Description

  • The component has been copied from data to be reused

UI/UX

Here is the component in storybook
image

Testing notes

Pull this branch, load up storybook and verify that this component can render properly, feel free to change the title/descrition.

Author checklist before assigning a reviewer

  • Reviewed my own code-diff.
    - [] Branch has been run in docker
  • PR assigned to me or an appropriate delegate.
  • Relevant labels added to the PR.
  • Appropriate tests have been added.
  • Lint and test workflows pass.

@Skoob1905 Skoob1905 added the enhancement New feature or request label Mar 21, 2024
@Skoob1905 Skoob1905 self-assigned this Mar 21, 2024
@Skoob1905 Skoob1905 requested a review from m4manjesh March 21, 2024 15:00
m4manjesh
m4manjesh requested changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@m4manjesh m4manjesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Component looks good and works as expected.
Just one thing , you missed to export it in src/index.ts.

@Skoob1905 Skoob1905 requested a review from m4manjesh March 22, 2024 10:08
m4manjesh
m4manjesh approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@m4manjesh m4manjesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Skoob1905 Skoob1905 merged commit 80567c0 into main Mar 22, 2024
3 checks passed
@Skoob1905 Skoob1905 deleted the enhancement/SelectorButton branch March 22, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4manjesh m4manjesh m4manjesh approved these changes

Assignees

@Skoob1905 Skoob1905

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Skoob1905 @m4manjesh