v0.1.3 Enhanced Buffer Handling for Large Diffs in evergit commit Command #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the existing test suite by adding integration tests for Git-related utilities. This includes setting up a temporary Git repository to validate behavior in an actual repository context, ensuring correctness of utilities like `isInGitRepo`, `hasGitChanges`, `stageAllFiles`, and `getCurrentBranchName`. - Created a temporary Git repository for test execution. - Added a test to verify repository setup without mocking. - Validated change detection with `hasGitChanges` after modifying a file. - Tested branch name retrieval with `getCurrentBranchName` in branch-agnostic manner. - Ensured test repository cleanup post-tests. Release-Note: Add integration tests for Git utilities enhancing test reliability. Signed-off-by: Ian Skelskey <ianskelskey@gmail.com>
- Update `main` function to accept command-line arguments, enabling easier testing - Export `main` function for use in tests; retain standalone execution capability - Add Jest tests for CLI commands to verify `commit` calls and help output - Mock `process.exit` to prevent Jest from terminating during tests - Suppress unwanted console errors and warnings in AI utility tests to ensure clarity Release-Note: Improve CLI testability by refactoring the main function and adding comprehensive test coverage. Signed-off-by: Ian Skelskey <ianskelskey@gmail.com>
Improves the getDiffForStagedFiles function by introducing a buffer size limit of 10 MB. Handles potential buffer overflow errors gracefully by advising the user to either reduce the number of staged files or increase the buffer size. Release-Note: Improve buffer handling in git diff function to prevent overflow Signed-off-by: Ian Skelskey <ianskelskey@gmail.com>
- Updated the version in README, package.json, and main.ts to 0.1.3 - Improved buffer handling in the `getDiffForStagedFiles` function - Enhanced the CLI main function and added corresponding tests - Added integration tests for Git utilities - Beautified codebase for increased readability Release-Note: Version updated to 0.1.3; enhanced CLI and code quality Signed-off-by: Ian Skelskey <ianskelskey@gmail.com>
- Introduced `setUserName` and `setUserEmail` functions in `src/util/git.ts` for configuring Git user identity. - Updated `git.test.ts` to include integration tests ensuring user identity can be set during repository setup. Release-Note: Add Git utilities for setting user name and email in repository setup. Signed-off-by: Ian Skelskey <ianskelskey@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses the ENOBUFS error encountered when executing the evergit commit command with a large number of staged changes, which previously caused spawnSync to exceed its default buffer size.
Changes Made
Testing Instructions
Additional Notes
This enhancement ensures evergit can handle larger commit diffs more reliably, and the custom error message improves the user experience by providing clear guidance when the buffer size is exceeded.