Update to latest tabs design. General feedback tweaks to samples and data. #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrustev
added
❌ status: awaiting-test
skrustev
added
❌ status: awaiting-test
skrustev
changed the title
skrustev
force-pushed
the
skrastev/general-feedback
branch
from
228b7c4 to
f42e9d0
Compare
IMinchev64
added
💥 status: in-test
IMinchev64
reviewed
Jan 30, 2025
src/styles.scss
Outdated
| @@ -11,4 +11,5 @@ html { | |||
|
|
|||
| body { | |||
| height: 100%; | |||
| min-width: 1600px; | |||
There was a problem hiding this comment.
Is this min width required and if it is, can we allow for a lower value? On smaller displays (i.e. on my laptop) the landing page is cropped in a slightly unpleasant way:
There was a problem hiding this comment.
I've decreased the min width to 1100px and the tabs to be a bit more flexible, but that seem to be minimum where the words are still visible.
IMinchev64
added
✅ status: verified
dkamburov
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the toolbar title for each sample.
Use more realistic prices for the ERP/Invenory sample.
Resolves #45
Resolves #51