Replace rollup with vite configuration #1364
Conversation
packages/cli/templates/webcomponents/igc-ts/projects/_base/files/tsconfig.json
Show resolved
Hide resolved
|
IMO you assuming this is going to be a Lit based application I highly recommend mimicking what the default Vite lit-ts template is doing. Most of the plugins the package enforces are opt-in and it should be up to the user to add and configure based on their specific use-case. |
|
Also, sticking to ES2021 and ESM output is an acceptable default option. The web components package targets evergreen browsers and ES2021 is a nice baseline which the relevant browsers already cover. |
…s2022, remove vite html plugin and vite plugin babel from the configuration, update vite to 6.0.10
| @@ -14,7 +14,7 @@ | |||
| }, | |||
| "scripts": { | |||
| "start": "tsc && concurrently -k -r \"tsc --watch\" \"wds\"", | |||
| "build": "rimraf dist && tsc && node --max-old-space-size=4096 node_modules/rollup/dist/bin/rollup -c rollup.config.mjs", | |||
| "build": "rimraf dist && tsc && node --max-old-space-size=4096 node_modules/vite/bin/vite.js build", | |||
There was a problem hiding this comment.
I have tested a new empty WC project with all components. All work with the exception of the navbar. It seems it has a wrong import
There was a problem hiding this comment.
The problem is reproduced in the master branch, so it's not related to this PR.
IvayloG
added
❌ status: awaiting-test
and removed
💥 status: in-test
❌ status: awaiting-test
labels
|
@IvayloG the problem with the nav-drawer is fixed. |
Closes #1052
Remove rollup for web components projects and add vite configuration.
Update versions of typescript, concurrently, rimraf, tslib, lit.