docs(dock-manager): add docking section #1437
Open
+30
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gedinakova
requested changes
Jan 17, 2025
|
|
||
| #### Root Docking | ||
|
|
||
| In this type of docking, the dragged pane will become a child of the Dock Manager `RootPane`. Depending on the root docking indicator position, the orientation and other properties of the root pane, the existing root pane will be modified or will be replaced with a newly created one. |
There was a problem hiding this comment.
Suggested change
| In this type of docking, the dragged pane will become a child of the Dock Manager `RootPane`. Depending on the root docking indicator position, the orientation and other properties of the root pane, the existing root pane will be modified or will be replaced with a newly created one. | |
| Root docking means the dragged pane will become a child of the Dock Manager `RootPane`. Depending on the root docking indicator position and the root pane's orientation and number of children, the existing root pane will be either modified or replaced with a newly created one. |
| @@ -294,6 +294,34 @@ this.dockManager.addEventListener('activePaneChanged', ev => { | |||
| }); | |||
| ``` | |||
|
|
|||
| ### Docking | |||
|
|
|||
| When you start dragging a floating pane, a different docking indicators will appear depending on the position of the dragged pane. There are four main types of docking - root docking, pane docking, document host docking and splitter docking. | |||
There was a problem hiding this comment.
Suggested change
| When you start dragging a floating pane, a different docking indicators will appear depending on the position of the dragged pane. There are four main types of docking - root docking, pane docking, document host docking and splitter docking. | |
| When you start dragging a pane, different docking indicators will appear depending on the element the dragged pane is currently over. There are four main types of docking - root docking, pane docking, document host docking and splitter docking. |
|
|
||
| #### Pane Docking | ||
|
|
||
| Docking indicators will appear in the center of a content pane or tab group pane when dragging the floating pane over it. Depending on the docking indicator position, the orientation and other properties of the target pane, the dragged pane will either become a child of the target pane's parent split pane, the target pane will be replaced with a newly created split pane or a tab group pane will be created. |
There was a problem hiding this comment.
"Depending on the docking indicator position, the orientation and other properties of the target pane, the dragged pane will either become a child of the target pane's parent split pane, the target pane will be replaced with a newly created split pane or a tab group pane will be created."
This whole statement doesn't correspond to docking into a CP/TGP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1418