closes #27; resubmit to CRAN

IndrajeetPatil · Feb 18, 2021 · 485fe46 · 485fe46
1 parent f87c6bf
commit 485fe46
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 18 deletions.
diff --git a/CRAN-RELEASE b/CRAN-RELEASE
@@ -1,2 +1,2 @@
-This package was submitted to CRAN on 2020-10-29.
-Once it is accepted, delete this file and tag the release (commit 68f7596).
+This package was submitted to CRAN on 2021-02-18.
+Once it is accepted, delete this file and tag the release (commit f87c6bf).
diff --git a/R/hybrid_easystats.R b/R/hybrid_easystats.R
@@ -15,7 +15,11 @@
 #' @param conf.int Indicating whether or not to include a confidence interval in
 #'   the tidied output (defaults to `TRUE`).
 #' @param ... Additional arguments that will be passed to
-#'   [parameters::model_parameters()] and [broom::tidy()].
+#'   [parameters::model_parameters()] or [broom::tidy()], whichever method
+#'   works. Note that you should pay attention to different naming conventions
+#'   across these packages. For example, the required confidence interval width
+#'   is specified using `ci` argument in `parameters::model_parameters`, while
+#'   using `conf.level` in `broom::tidy`.
 #'
 #' @return A data frame of indices related to the model's parameters.
 #'

diff --git a/man/tidy_parameters.Rd b/man/tidy_parameters.Rd
diff --git a/tests/testthat/test-generics.R b/tests/testthat/test-generics.R
@@ -3,8 +3,6 @@
 test_that(
   desc = "`tidy()` works",
   code = {
-    # skip_on_cran()
-
     library(lme4)
     set.seed(123)
 
@@ -25,8 +23,6 @@ test_that(
 test_that(
   desc = "`glance()` works",
   code = {
-    # skip_on_cran()
-
     library(lme4)
     set.seed(123)
 
@@ -53,8 +49,6 @@ test_that(
 test_that(
   desc = "`augment()` works",
   code = {
-    # skip_on_cran()
-
     library(lme4)
     set.seed(123)
 

diff --git a/tests/testthat/test-grouped_generics.R b/tests/testthat/test-grouped_generics.R
@@ -3,8 +3,6 @@
 test_that(
   desc = "`grouped_tidy()` works",
   code = {
-    # skip_on_cran()
-
     library(lme4)
     set.seed(123)
 
@@ -40,8 +38,6 @@ test_that(
 test_that(
   desc = "`grouped_glance()` works",
   code = {
-    # skip_on_cran()
-
     library(lme4)
     set.seed(123)
 
@@ -74,8 +70,6 @@ test_that(
 test_that(
   desc = "`grouped_augment()` works",
   code = {
-    # skip_on_cran()
-
     library(lme4)
     set.seed(123)
 

diff --git a/tests/testthat/test-hybrid_generics.R b/tests/testthat/test-hybrid_generics.R
@@ -3,8 +3,6 @@
 test_that(
   desc = "hybrid methods works",
   code = {
-    # skip_on_cran()
-
     library(lme4)
     # merMord
     set.seed(123)