fix: remove unnecessary toolchain includes and set the minimum Go version to 1.22 #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion to 1.22 Closes #133 Drop "minimum virus" from grpc-go
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
=======================================
Coverage 88.11% 88.11%
=======================================
Files 15 15
Lines 1346 1346
=======================================
Hits 1186 1186
Misses 134 134
Partials 26 26 ☔ View full report in Codecov by Sentry. |
vlastahajek
approved these changes
Jan 22, 2025
majew7
reviewed
Jan 22, 2025
There was a problem hiding this comment.
Looks good @bednar. Yes, it looks to revert the go.mod minimum Go version accidentally formed: #115
And it appears that google.golang.org/grpc v1.68.0 is still in go.mod. Do you need to retrieve google.golang.org/grpc v1.69.x too? Or perhaps v.68.1?
I saw a patch release on grpc-go/releases
What are your thoughts?
|
Got it! I realize I made a interpretation mistake.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #133
Proposed Changes
Drop "minimum virus" which comes from grpc-go ... for more info see #133.
Checklist