Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: proxy and custom SSL certificates support #141

Merged
merged 6 commits into from
Feb 27, 2025

Conversation

jansimonb
Copy link
Contributor

@jansimonb jansimonb commented Feb 25, 2025

Closes #139

Proposed Changes

  • Add SSLRootsFilePath field into ClientConfig to configure additional SSL root certificates
  • Add Proxy field into ClientConfig to set proxy URL

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 91.42857% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.29%. Comparing base (ed5a8a0) to head (46a1181).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
influxdb3/client.go 94.00% 2 Missing and 1 partial ⚠️
influxdb3/query.go 85.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   91.15%   91.29%   +0.14%     
==========================================
  Files          16       16              
  Lines        1356     1413      +57     
==========================================
+ Hits         1236     1290      +54     
- Misses         91       93       +2     
- Partials       29       30       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jansimonb jansimonb marked this pull request as ready for review February 26, 2025 10:10
@jansimonb jansimonb removed the request for review from bednar February 26, 2025 11:33
Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything committed to here looks good. Tests pass locally for me. However it might be useful to have an example of using the new configuration properties SSLRootsFilePath and Proxy in examples_test.go (https://github.com/InfluxCommunity/influxdb3-go/blob/main/influxdb3/example_test.go).

I believe they will then render in the go package repository. https://pkg.go.dev/github.com/InfluxCommunity/influxdb3-go/v2/influxdb3#example-New

It has been a while since I've made these kinds of updates to go but if I recall correctly, this is where such doc examples can be added.

Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jansimonb jansimonb merged commit 8aa0156 into main Feb 27, 2025
11 checks passed
@jansimonb jansimonb deleted the feat/proxy-and-ssl-roots-support branch February 27, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add proxy value to client configuration
2 participants