-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: proxy and custom SSL certificates support #141
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
==========================================
+ Coverage 91.15% 91.29% +0.14%
==========================================
Files 16 16
Lines 1356 1413 +57
==========================================
+ Hits 1236 1290 +54
- Misses 91 93 +2
- Partials 29 30 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything committed to here looks good. Tests pass locally for me. However it might be useful to have an example of using the new configuration properties SSLRootsFilePath
and Proxy
in examples_test.go
(https://github.com/InfluxCommunity/influxdb3-go/blob/main/influxdb3/example_test.go).
I believe they will then render in the go package repository. https://pkg.go.dev/github.com/InfluxCommunity/influxdb3-go/v2/influxdb3#example-New
It has been a while since I've made these kinds of updates to go but if I recall correctly, this is where such doc examples can be added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Closes #139
Proposed Changes
SSLRootsFilePath
field intoClientConfig
to configure additional SSL root certificatesProxy
field intoClientConfig
to set proxy URLChecklist