Merge branch 'develop'

Informatievlaanderen · Sep 4, 2024 · e8bc09e · e8bc09e
2 parents d47917c + 737a94c
commit e8bc09e
Show file tree

Hide file tree

Showing 12 changed files with 34 additions and 12 deletions.
diff --git a/common/pom.xml b/common/pom.xml
@@ -5,7 +5,7 @@
     <parent>
         <artifactId>magda</artifactId>
         <groupId>be.vlaanderen.vip.mock</groupId>
-        <version>2.43.0</version>
+        <version>2.44.0</version>
     </parent>
     <modelVersion>4.0.0</modelVersion>
 

diff --git a/interfaces/pom.xml b/interfaces/pom.xml
@@ -5,7 +5,7 @@
   <parent>
     <artifactId>magda</artifactId>
     <groupId>be.vlaanderen.vip.mock</groupId>
-    <version>2.43.0</version>
+    <version>2.44.0</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
 

diff --git a/magdaconnector/pom.xml b/magdaconnector/pom.xml
@@ -5,7 +5,7 @@
   <parent>
     <artifactId>magda</artifactId>
     <groupId>be.vlaanderen.vip.mock</groupId>
-    <version>2.43.0</version>
+    <version>2.44.0</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
 

diff --git a/magdamock-starter/pom.xml b/magdamock-starter/pom.xml
@@ -8,7 +8,7 @@
 	<parent>
 		<artifactId>magda</artifactId>
 		<groupId>be.vlaanderen.vip.mock</groupId>
-		<version>2.43.0</version>
+		<version>2.44.0</version>
 	</parent>
 	<artifactId>magdamock-starter</artifactId>
 

diff --git a/magdamock/pom.xml b/magdamock/pom.xml
@@ -3,7 +3,7 @@
   <parent>
     <artifactId>magda</artifactId>
     <groupId>be.vlaanderen.vip.mock</groupId>
-    <version>2.43.0</version>
+    <version>2.44.0</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
 

diff --git a/...ck/src/main/resources/magda_simulator/Persoon/GeefDossierHandicap/03.00.0000/notfound.xml b/...ck/src/main/resources/magda_simulator/Persoon/GeefDossierHandicap/03.00.0000/notfound.xml
@@ -31,7 +31,6 @@
                             <code>MSG00100</code>
                             <description>Treatment successful, but no data found at the supplier.</description>
                         </status>
-                        <ssin>00000000000</ssin>
                         <results>
                             <dgphResult>
                                 <status>

diff --git a/...mock/src/test/java/be/vlaanderen/vip/mock/magda/client/GeefDossierHandicapByDateTest.java b/...mock/src/test/java/be/vlaanderen/vip/mock/magda/client/GeefDossierHandicapByDateTest.java
@@ -11,6 +11,7 @@
 import java.util.UUID;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.junit.jupiter.api.Assertions.assertNull;
 
 @Slf4j
 class GeefDossierHandicapByDateTest extends MockTestBase {
@@ -97,6 +98,6 @@ void geefDossierHandicapByDateGeeftAntwoordNotFound() {
         assertThat(status).isEqualTo("NO_DATA_FOUND");
 
         var ssin = doc.getValue("//Antwoorden/Antwoord/Inhoud/ConsultFilesByDateResponse/ssin");
-        assertThat(ssin).isEqualTo("00010100173");
+        assertNull(ssin);
     }
 }
diff --git a/...java/be/vlaanderen/vip/mock/magda/client/simulators/GeefDossierHandicapSimulatorTest.java b/...java/be/vlaanderen/vip/mock/magda/client/simulators/GeefDossierHandicapSimulatorTest.java
@@ -10,12 +10,13 @@
 
 import static be.vlaanderen.vip.mock.magda.client.simulators.SOAPSimulatorBuilder.*;
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNull;
 
 class GeefDossierHandicapSimulatorTest {
 
     @Test
     void fillsInSsinFromByDateRequest() throws URISyntaxException, IOException {
-        var ssin = "00010100173";
+        var ssin = "10712995476";
 
         var request = MagdaDocumentBuilder.request(Map.of(
                 "Context", Map.of(
@@ -35,4 +36,25 @@ void fillsInSsinFromByDateRequest() throws URISyntaxException, IOException {
 
         assertEquals(ssin, response.getValue("//Antwoorden/Antwoord/Inhoud/ConsultFilesByDateResponse/ssin"));
     }
+    @Test
+    void ssinNotFilledInWhenNoDataFound() throws URISyntaxException, IOException {
+        var ssin = "00010100173";
+        var request = MagdaDocumentBuilder.request(Map.of(
+                "Context", Map.of(
+                        "Naam", "GeefDossierHandicap",
+                        "Versie", "03.00.0000"),
+                "Vragen", Map.of(
+                        "Vraag", Map.of(
+                                "Inhoud", Map.of(
+                                        "Criteria", Map.of(
+                                                "ConsultFilesByDateCriteria", Map.of(
+                                                        "ssin", ssin
+                                                )))))));
+
+        var simulator = new GeefDossierHandicapSimulator(ResourceFinders.magdaSimulator(), PERSOON, KEY_SSIN);
+
+        var response = simulator.send(request);
+
+        assertNull(response.getValue("//Antwoorden/Antwoord/Inhoud/ConsultFilesByDateResponse/ssin"));
+    }
 }
diff --git a/magdaservice/pom.xml b/magdaservice/pom.xml
@@ -5,7 +5,7 @@
   <parent>
     <artifactId>magda</artifactId>
     <groupId>be.vlaanderen.vip.mock</groupId>
-    <version>2.43.0</version>
+    <version>2.44.0</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
 

diff --git a/pom.xml b/pom.xml
@@ -10,7 +10,7 @@
 	</parent>
 	<groupId>be.vlaanderen.vip.mock</groupId>
 	<artifactId>magda</artifactId>
-	<version>2.43.0</version>
+	<version>2.44.0</version>
 	<name>magdaservice</name>
 	<description>MAGDA diensten Mock voor afnemers</description>
 	<properties>

diff --git a/signing/pom.xml b/signing/pom.xml
@@ -5,7 +5,7 @@
     <parent>
         <artifactId>magda</artifactId>
         <groupId>be.vlaanderen.vip.mock</groupId>
-        <version>2.43.0</version>
+        <version>2.44.0</version>
     </parent>
     <modelVersion>4.0.0</modelVersion>
 

diff --git a/tester/pom.xml b/tester/pom.xml
@@ -5,7 +5,7 @@
     <parent>
         <artifactId>magda</artifactId>
         <groupId>be.vlaanderen.vip.mock</groupId>
-        <version>2.43.0</version>
+        <version>2.44.0</version>
     </parent>
     <modelVersion>4.0.0</modelVersion>