Skip to content

Commit

Permalink
fix: command provenance should be set after idempotency check
Browse files Browse the repository at this point in the history
  • Loading branch information
jvandaal committed Jan 9, 2024
1 parent 167f0d7 commit cb8c11a
Show file tree
Hide file tree
Showing 37 changed files with 104 additions and 128 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,5 @@ protected BuildingLambdaRequest(
IDictionary<string, object?> metadata)
: base(messageGroupId, ticketId, ifMatchHeaderValue, provenance, metadata)
{ }

protected Provenance CommandProvenance => new Provenance(
SystemClock.Instance.GetCurrentInstant(),
Provenance.Application,
Provenance.Reason,
Provenance.Operator,
Provenance.Modification,
Provenance.Organisation);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public ChangeBuildingMeasurement ToCommand()
new BuildingPersistentLocalId(BuildingPersistentLocalId),
Request.GrbData.GeometriePolygoon.ToExtendedWkbGeometry(),
Request.GrbData.ToBuildingGrbData(),
CommandProvenance);
Provenance);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public ChangeBuildingOutline ToCommand()
return new ChangeBuildingOutline(
new BuildingPersistentLocalId(BuildingPersistentLocalId),
Request.GeometriePolygoon.ToExtendedWkbGeometry(),
CommandProvenance);
Provenance);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public CorrectBuildingMeasurement ToCommand()
new BuildingPersistentLocalId(BuildingPersistentLocalId),
Request.GrbData.GeometriePolygoon.ToExtendedWkbGeometry(),
Request.GrbData.ToBuildingGrbData(),
CommandProvenance);
Provenance);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public CorrectBuildingNotRealizationLambdaRequest(
/// <returns>CorrectBuildingNotRealization.</returns>
public CorrectBuildingNotRealization ToCommand()
{
return new CorrectBuildingNotRealization(new BuildingPersistentLocalId(BuildingPersistentLocalId), CommandProvenance);
return new CorrectBuildingNotRealization(new BuildingPersistentLocalId(BuildingPersistentLocalId), Provenance);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public CorrectBuildingRealizationLambdaRequest(
/// <returns>CorrectBuildingRealization.</returns>
public CorrectBuildingRealization ToCommand()
{
return new CorrectBuildingRealization(new BuildingPersistentLocalId(BuildingPersistentLocalId), CommandProvenance);
return new CorrectBuildingRealization(new BuildingPersistentLocalId(BuildingPersistentLocalId), Provenance);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public CorrectPlaceBuildingUnderConstructionLambdaRequest(
/// <returns>CorrectBuildingPlaceUnderConstruction.</returns>
public CorrectBuildingPlaceUnderConstruction ToCommand()
{
return new CorrectBuildingPlaceUnderConstruction(new BuildingPersistentLocalId(BuildingPersistentLocalId), CommandProvenance);
return new CorrectBuildingPlaceUnderConstruction(new BuildingPersistentLocalId(BuildingPersistentLocalId), Provenance);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public DemolishBuilding ToCommand()
{
return new DemolishBuilding(new BuildingPersistentLocalId(BuildingPersistentLocalId),
Request.GrbData.ToBuildingGrbData(),
CommandProvenance);
Provenance);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public MeasureBuilding ToCommand()
new BuildingPersistentLocalId(BuildingPersistentLocalId),
Request.GrbData.GeometriePolygoon.ToExtendedWkbGeometry(),
Request.GrbData.ToBuildingGrbData(),
CommandProvenance);
Provenance);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public MergeBuildings ToCommand()
Request.GeometriePolygoon.ToExtendedWkbGeometry(),
Request.SamenvoegenGebouwen
.Select(x => new BuildingPersistentLocalId(Convert.ToInt32(x.AsIdentifier().Map(s => s).Value))),
CommandProvenance);
Provenance);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public NotRealizeBuildingLambdaRequest(string messageGroupId, NotRealizeBuilding
/// <returns>NotRealizeBuilding.</returns>
public NotRealizeBuilding ToCommand()
{
return new NotRealizeBuilding(new BuildingPersistentLocalId(BuildingPersistentLocalId), CommandProvenance);
return new NotRealizeBuilding(new BuildingPersistentLocalId(BuildingPersistentLocalId), Provenance);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public PlaceBuildingUnderConstructionLambdaRequest(
/// <returns>PlaceBuildingUnderConstruction.</returns>
public PlaceBuildingUnderConstruction ToCommand()
{
return new PlaceBuildingUnderConstruction(new BuildingPersistentLocalId(BuildingPersistentLocalId), CommandProvenance);
return new PlaceBuildingUnderConstruction(new BuildingPersistentLocalId(BuildingPersistentLocalId), Provenance);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public PlanBuilding ToCommand()
return new PlanBuilding(
BuildingPersistentLocalId,
Request.GeometriePolygoon.ToExtendedWkbGeometry(),
CommandProvenance);
Provenance);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public RealizeAndMeasureUnplannedBuilding ToCommand()
new BuildingPersistentLocalId(BuildingPersistentLocalId),
Request.GrbData.GeometriePolygoon.ToExtendedWkbGeometry(),
Request.GrbData.ToBuildingGrbData(),
CommandProvenance);
Provenance);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public RealizeBuildingLambdaRequest(
/// <returns>RealizeBuilding.</returns>
public RealizeBuilding ToCommand()
{
return new RealizeBuilding(new BuildingPersistentLocalId(BuildingPersistentLocalId), CommandProvenance);
return new RealizeBuilding(new BuildingPersistentLocalId(BuildingPersistentLocalId), Provenance);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public RemoveBuildingLambdaRequest(string messageGroupId, RemoveBuildingSqsReque
/// <returns>RemoveBuilding.</returns>
public RemoveBuilding ToCommand()
{
return new RemoveBuilding(new BuildingPersistentLocalId(BuildingPersistentLocalId), CommandProvenance);
return new RemoveBuilding(new BuildingPersistentLocalId(BuildingPersistentLocalId), Provenance);
}
}
}
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
namespace BuildingRegistry.Api.BackOffice.Handlers.Lambda.Requests.BuildingUnit
{
using Abstractions.Building.Validators;
using Abstractions.BuildingUnit.Requests;
using Abstractions.BuildingUnit.SqsRequests;
using BuildingRegistry.Api.BackOffice.Abstractions.Building.Validators;
using BuildingRegistry.Api.BackOffice.Abstractions.BuildingUnit.Requests;
using BuildingRegistry.Api.BackOffice.Abstractions.BuildingUnit.SqsRequests;
using BuildingRegistry.Building;
using BuildingRegistry.Building.Commands;

Expand Down Expand Up @@ -38,7 +37,7 @@ public AttachAddressToBuildingUnit ToCommand()
BuildingPersistentLocalId,
new BuildingUnitPersistentLocalId(BuildingUnitPersistentLocalId),
new AddressPersistentLocalId(addressPersistentLocalId),
CommandProvenance);
Provenance);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,5 @@ protected BuildingUnitLambdaRequest(
IDictionary<string, object?> metadata)
: base(messageGroupId, ticketId, ifMatchHeaderValue, provenance, metadata)
{ }

protected Provenance CommandProvenance => new Provenance(
SystemClock.Instance.GetCurrentInstant(),
Provenance.Application,
Provenance.Reason,
Provenance.Operator,
Provenance.Modification,
Provenance.Organisation);
}
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
namespace BuildingRegistry.Api.BackOffice.Handlers.Lambda.Requests.BuildingUnit
{
using Abstractions.BuildingUnit.Requests;
using Abstractions.BuildingUnit.SqsRequests;
using BuildingRegistry.Api.BackOffice.Abstractions.BuildingUnit.Requests;
using BuildingRegistry.Api.BackOffice.Abstractions.BuildingUnit.SqsRequests;
using BuildingRegistry.Building;
using BuildingRegistry.Building.Commands;
using IHasBuildingUnitPersistentLocalId = Abstractions.IHasBuildingUnitPersistentLocalId;
Expand Down Expand Up @@ -32,7 +31,7 @@ public CorrectBuildingUnitDeregulation ToCommand()
return new CorrectBuildingUnitDeregulation(
BuildingPersistentLocalId,
new BuildingUnitPersistentLocalId(BuildingUnitPersistentLocalId),
CommandProvenance);
Provenance);
}
}
}
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
namespace BuildingRegistry.Api.BackOffice.Handlers.Lambda.Requests.BuildingUnit
{
using Abstractions.BuildingUnit.Requests;
using Abstractions.BuildingUnit.SqsRequests;
using Be.Vlaanderen.Basisregisters.GrAr.Provenance;
using BuildingRegistry.Api.BackOffice.Abstractions.BuildingUnit.Requests;
using BuildingRegistry.Api.BackOffice.Abstractions.BuildingUnit.SqsRequests;
using BuildingRegistry.Building;
using BuildingRegistry.Building.Commands;
using IHasBuildingUnitPersistentLocalId = Abstractions.IHasBuildingUnitPersistentLocalId;
Expand Down Expand Up @@ -34,7 +32,7 @@ public CorrectBuildingUnitNotRealization ToCommand()
return new CorrectBuildingUnitNotRealization(
BuildingPersistentLocalId,
new BuildingUnitPersistentLocalId(BuildingUnitPersistentLocalId),
CommandProvenance);
Provenance);
}
}
}
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
namespace BuildingRegistry.Api.BackOffice.Handlers.Lambda.Requests.BuildingUnit
{
using Abstractions.Building;
using Abstractions.BuildingUnit.Converters;
using Abstractions.BuildingUnit.Requests;
using Abstractions.BuildingUnit.SqsRequests;
using Be.Vlaanderen.Basisregisters.GrAr.Provenance;
using BuildingRegistry.Api.BackOffice.Abstractions.Building;
using BuildingRegistry.Api.BackOffice.Abstractions.BuildingUnit.Converters;
using BuildingRegistry.Api.BackOffice.Abstractions.BuildingUnit.Requests;
using BuildingRegistry.Api.BackOffice.Abstractions.BuildingUnit.SqsRequests;
using BuildingRegistry.Building;
using BuildingRegistry.Building.Commands;

Expand Down Expand Up @@ -36,7 +34,7 @@ public CorrectBuildingUnitPosition ToCommand()
new BuildingUnitPersistentLocalId(BuildingUnitPersistentLocalId),
Request.PositieGeometrieMethode.Map(),
string.IsNullOrWhiteSpace(Request.Positie) ? null : Request.Positie.ToExtendedWkbGeometry(),
CommandProvenance);
Provenance);
}
}
}
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
namespace BuildingRegistry.Api.BackOffice.Handlers.Lambda.Requests.BuildingUnit
{
using Abstractions.BuildingUnit.Requests;
using Abstractions.BuildingUnit.SqsRequests;
using Be.Vlaanderen.Basisregisters.GrAr.Provenance;
using BuildingRegistry.Api.BackOffice.Abstractions.BuildingUnit.Requests;
using BuildingRegistry.Api.BackOffice.Abstractions.BuildingUnit.SqsRequests;
using BuildingRegistry.Building;
using BuildingRegistry.Building.Commands;
using IHasBuildingUnitPersistentLocalId = Abstractions.IHasBuildingUnitPersistentLocalId;
Expand All @@ -29,7 +27,7 @@ public CorrectBuildingUnitRealizationLambdaRequest(
/// <returns>CorrectBuildingUnitRealization.</returns>
public CorrectBuildingUnitRealization ToCommand()
{
return new CorrectBuildingUnitRealization(BuildingPersistentLocalId, new BuildingUnitPersistentLocalId(BuildingUnitPersistentLocalId), CommandProvenance);
return new CorrectBuildingUnitRealization(BuildingPersistentLocalId, new BuildingUnitPersistentLocalId(BuildingUnitPersistentLocalId), Provenance);
}
}
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
namespace BuildingRegistry.Api.BackOffice.Handlers.Lambda.Requests.BuildingUnit
{
using Abstractions.BuildingUnit.Requests;
using Abstractions.BuildingUnit.SqsRequests;
using BuildingRegistry.Api.BackOffice.Abstractions.BuildingUnit.Requests;
using BuildingRegistry.Api.BackOffice.Abstractions.BuildingUnit.SqsRequests;
using BuildingRegistry.Building;
using BuildingRegistry.Building.Commands;
using IHasBuildingUnitPersistentLocalId = Abstractions.IHasBuildingUnitPersistentLocalId;
Expand All @@ -27,7 +26,10 @@ public CorrectBuildingUnitRegularizationLambdaRequest(
/// <returns>CorrectBuildingUnitRealization.</returns>
public CorrectBuildingUnitRegularization ToCommand()
{
return new CorrectBuildingUnitRegularization(BuildingPersistentLocalId, new BuildingUnitPersistentLocalId(BuildingUnitPersistentLocalId), CommandProvenance);
return new CorrectBuildingUnitRegularization(
BuildingPersistentLocalId,
new BuildingUnitPersistentLocalId(BuildingUnitPersistentLocalId),
Provenance);
}
}
}
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
namespace BuildingRegistry.Api.BackOffice.Handlers.Lambda.Requests.BuildingUnit
{
using Abstractions.BuildingUnit.Requests;
using Abstractions.BuildingUnit.SqsRequests;
using Be.Vlaanderen.Basisregisters.GrAr.Provenance;
using BuildingRegistry.Api.BackOffice.Abstractions.BuildingUnit.Requests;
using BuildingRegistry.Api.BackOffice.Abstractions.BuildingUnit.SqsRequests;
using BuildingRegistry.Building;
using BuildingRegistry.Building.Commands;
using IHasBuildingUnitPersistentLocalId = Abstractions.IHasBuildingUnitPersistentLocalId;
Expand All @@ -29,7 +27,7 @@ public CorrectBuildingUnitRetirementLambdaRequest(
/// <returns>CorrectBuildingUnitRetirement.</returns>
public CorrectBuildingUnitRetirement ToCommand()
{
return new CorrectBuildingUnitRetirement(BuildingPersistentLocalId, new BuildingUnitPersistentLocalId(BuildingUnitPersistentLocalId), CommandProvenance);
return new CorrectBuildingUnitRetirement(BuildingPersistentLocalId, new BuildingUnitPersistentLocalId(BuildingUnitPersistentLocalId), Provenance);
}
}
}
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
namespace BuildingRegistry.Api.BackOffice.Handlers.Lambda.Requests.BuildingUnit
{
using Abstractions.BuildingUnit.Requests;
using Abstractions.BuildingUnit.SqsRequests;
using Be.Vlaanderen.Basisregisters.GrAr.Provenance;
using BuildingRegistry.Api.BackOffice.Abstractions.BuildingUnit.Requests;
using BuildingRegistry.Api.BackOffice.Abstractions.BuildingUnit.SqsRequests;
using BuildingRegistry.Building;
using BuildingRegistry.Building.Commands;
using IHasBuildingUnitPersistentLocalId = Abstractions.IHasBuildingUnitPersistentLocalId;
Expand All @@ -29,7 +27,7 @@ public DeregulateBuildingUnitLambdaRequest(
/// <returns>DeregulateBuildingUnit.</returns>
public DeregulateBuildingUnit ToCommand()
{
return new DeregulateBuildingUnit(BuildingPersistentLocalId, new BuildingUnitPersistentLocalId(BuildingUnitPersistentLocalId), CommandProvenance);
return new DeregulateBuildingUnit(BuildingPersistentLocalId, new BuildingUnitPersistentLocalId(BuildingUnitPersistentLocalId), Provenance);
}
}
}
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
namespace BuildingRegistry.Api.BackOffice.Handlers.Lambda.Requests.BuildingUnit
{
using Abstractions.Building.Validators;
using Abstractions.BuildingUnit.Requests;
using Abstractions.BuildingUnit.SqsRequests;
using BuildingRegistry.Api.BackOffice.Abstractions.Building.Validators;
using BuildingRegistry.Api.BackOffice.Abstractions.BuildingUnit.Requests;
using BuildingRegistry.Api.BackOffice.Abstractions.BuildingUnit.SqsRequests;
using BuildingRegistry.Building;
using BuildingRegistry.Building.Commands;

Expand Down Expand Up @@ -38,7 +37,7 @@ public DetachAddressFromBuildingUnit ToCommand()
BuildingPersistentLocalId,
new BuildingUnitPersistentLocalId(BuildingUnitPersistentLocalId),
new AddressPersistentLocalId(addressPersistentLocalId),
CommandProvenance);
Provenance);
}
}
}
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
namespace BuildingRegistry.Api.BackOffice.Handlers.Lambda.Requests.BuildingUnit
{
using Abstractions.BuildingUnit.Requests;
using Abstractions.BuildingUnit.SqsRequests;
using Be.Vlaanderen.Basisregisters.GrAr.Provenance;
using BuildingRegistry.Api.BackOffice.Abstractions.BuildingUnit.Requests;
using BuildingRegistry.Api.BackOffice.Abstractions.BuildingUnit.SqsRequests;
using BuildingRegistry.Building;
using BuildingRegistry.Building.Commands;
using IHasBuildingUnitPersistentLocalId = Abstractions.IHasBuildingUnitPersistentLocalId;
Expand Down Expand Up @@ -32,7 +30,7 @@ public NotRealizeBuildingUnit ToCommand()
return new NotRealizeBuildingUnit(
BuildingPersistentLocalId,
new BuildingUnitPersistentLocalId(BuildingUnitPersistentLocalId),
CommandProvenance);
Provenance);
}
}
}
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
namespace BuildingRegistry.Api.BackOffice.Handlers.Lambda.Requests.BuildingUnit
{
using Abstractions.Building;
using Abstractions.BuildingUnit.Converters;
using Abstractions.BuildingUnit.Requests;
using Abstractions.BuildingUnit.SqsRequests;
using Be.Vlaanderen.Basisregisters.GrAr.Provenance;
using BuildingRegistry.Api.BackOffice.Abstractions.Building;
using BuildingRegistry.Api.BackOffice.Abstractions.BuildingUnit.Converters;
using BuildingRegistry.Api.BackOffice.Abstractions.BuildingUnit.Requests;
using BuildingRegistry.Building;
using BuildingRegistry.Building.Commands;

Expand Down Expand Up @@ -34,7 +33,7 @@ public PlanBuildingUnit ToCommand()
string.IsNullOrWhiteSpace(Request.Positie) ? null : Request.Positie.ToExtendedWkbGeometry(),
Request.Functie.Map(),
Request.AfwijkingVastgesteld,
CommandProvenance);
Provenance);
}
}
}
Loading

0 comments on commit cb8c11a

Please sign in to comment.