Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add integration database version projections #1144

Merged
merged 21 commits into from
Feb 7, 2024
Merged

feat: add integration database version projections #1144

merged 21 commits into from
Feb 7, 2024

Conversation

jvandaal
Copy link
Contributor

@jvandaal jvandaal commented Jan 16, 2024 •
edited by emalfroy
Loading

Todo's

  • Finish building unit tests for v2 events.
  • Add CreatedOnVersionTimeStamp
  • Add Building OsloStatus + OsloGeometryMethod
  • Add BuildingUnit OsloStatus + OsloFunction + OsloGeometryMethod
  • PersistentLocalIdFinder should query on stream Id instead of OriginalId
  • throw if building(Unit)PersistentLocal was not found
  • Start a new version without the legacy BuildingId on BuildingWasMigrated
  • Find AddressPersistentLocalId based on AddressId
  • Add tests for the building legacy events
  • Remove NisCode
  • Add tests for the building unit legacy events
  • Register projections (don't forget to register IPersistentLocalIdFinder needs events connection string)
  • What about BuildingUnitReaddressSyndication ?
  • EF migrations

@jvandaal jvandaal force-pushed the integration-db-versions branch from 50a7c36 to eb94f29 Compare January 16, 2024 15:59
@jvandaal jvandaal force-pushed the integration-db-versions branch 7 times, most recently from 6ceadd7 to 05cdd72 Compare February 2, 2024 08:09
@emalfroy emalfroy force-pushed the integration-db-versions branch from 3a7b2a7 to 71d6947 Compare February 2, 2024 10:05
@jvandaal jvandaal force-pushed the integration-db-versions branch 4 times, most recently from 8fdc80d to 0fd0ad7 Compare February 6, 2024 07:47
jvandaal added 17 commits February 6, 2024 15:30
@jvandaal @emalfroy
feat: add integration database version projections
43f9d54
@jvandaal @emalfroy
feat: add CreatedOnVersionTimeStamp
434d60d
@jvandaal @emalfroy
feat: add building oslo status
ad0bb2e
@jvandaal @emalfroy
feat: add building unit oslo status
16b0256
@jvandaal @emalfroy
feat: add building oslo geometry method
7e0c9a4
@jvandaal @emalfroy
feat: add building unit oslo function
d487feb
@jvandaal @emalfroy
feat: add building unit oslo geometry method
d94af3f
@jvandaal @emalfroy
perf: PersistentLocalIdFinder should filter on Id instead of IdOriginal
8d46be1
@jvandaal @emalfroy
fix: throw when persistentlocalid couldn't be found by legacy id
aaba963
@jvandaal @emalfroy
fix: BuildingWasMigrated starts new BuildingVersion
d74e1d9
@jvandaal @emalfroy
Find and store AddressPersistentLocalId by AddressId
7b8ff56
@jvandaal @emalfroy
chore: split up tests classes to reduce length
bbf8071
@jvandaal @emalfroy
test: add building version tests for legacy events
7d54efe
@jvandaal @emalfroy
test: add building unit version tests for building legacy events
574cac9
@jvandaal @emalfroy
test: add building unit version tests for building unit legacy events
9a7f9d3
@jvandaal @emalfroy
test: refactor legacy building events tests
f717854
@jvandaal @emalfroy
test: correct tests by using string value instead of value object
d8c5a8e
@emalfroy emalfroy force-pushed the integration-db-versions branch from a81675e to de0287c Compare February 6, 2024 14:30
@emalfroy emalfroy marked this pull request as ready for review February 6, 2024 14:30
@emalfroy emalfroy requested a review from a team as a code owner February 6, 2024 14:30
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
1 Security Hotspot
91.3% Coverage on New Code
5.1% Duplication on New Code

See analysis details on SonarCloud

@ArneD ArneD merged commit d528f5d into main Feb 7, 2024
2 checks passed
@ArneD ArneD deleted the integration-db-versions branch February 7, 2024 09:53
@basisregisters-vlaanderen
Copy link
Contributor

🎉 This PR is included in version 3.100.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emalfroy emalfroy emalfroy approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jvandaal @basisregisters-vlaanderen @emalfroy @ArneD