Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Move and Paste Argument Flags #54

Merged
merged 6 commits into from
Jan 6, 2024

Conversation

12rcu
Copy link
Contributor

@12rcu 12rcu commented Dec 9, 2023

Overview

Some flags of the paste and move command are wrong or missing, this PR adds the missing flags and tries to fix the wrong flags.

Description

Move command argument flags

Source: https://github.com/IntellectualSites/FastAsyncWorldEdit/blob/fe626a92e14ec1fb9db38a52895c131c9230443b/worldedit-core/src/main/java/com/sk89q/worldedit/command/RegionCommands.java#L539

  • -b includes moving biomes, not excluding them
  • -e includes moving entities, not excluding them
  • -m added this flag

Paste command argument flags

Source: https://github.com/IntellectualSites/FastAsyncWorldEdit/blob/fe626a92e14ec1fb9db38a52895c131c9230443b/worldedit-core/src/main/java/com/sk89q/worldedit/command/ClipboardCommands.java#L500

  • -b includes moving biomes, not excluding them
  • -e includes moving entities, not excluding them
  • -m added this flag
  • -n added this flag

Submitter Checklist

Preview Give feedback

@12rcu 12rcu requested a review from a team as a code owner December 9, 2023 22:51
@12rcu 12rcu changed the title Added Move and Paste Arguemnt Flags Added Move and Paste Argument Flags Dec 9, 2023
@NotMyFault
Copy link
Contributor

Hey, thanks for the PR, but it looks like you got a typo there :)

Screenshot 2024-01-06 at 11 25 56

Copy link
Contributor

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NotMyFault NotMyFault merged commit 0eeb156 into IntellectualSites:main Jan 6, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants