#1189 more helpful exception when a license is missing.

Intermesh · Dec 16, 2024 · fac6382 · fac6382
1 parent bf0561a
commit fac6382
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,4 +1,5 @@
 - Tasks: fix several bugs in ICS import
+- OAuth2 client: return more informative exception if a session variable is missing.
 
 12-12-2024: 6.8.90
 - Core: Show database error on upgrade

diff --git a/www/go/modules/community/oauth2client/controller/Oauth2Client.php b/www/go/modules/community/oauth2client/controller/Oauth2Client.php
@@ -62,9 +62,9 @@ public function callback()
 		if (!empty($_GET['error'])) {
 			throw new Exception(500, 'Got error: ' . htmlspecialchars($_GET['error'], ENT_QUOTES));
 		}
-//		if (!isset($_SESSION['accountId'])) {
-//			throw new Exception(500, 'Invalid parameter');
-//		}
+		if (!isset($_SESSION['accountId']) || !isset($_SESSION['oauth2state'])) {
+			throw new Exception(500, 'A session variable is missing. Please retry with a new session.');
+		}
 
 		if (empty($_GET['state']) || ($_GET['state'] !== $_SESSION['oauth2state'])) {