Skip to content

Releases: IsaacRF/github-ngsearch

v1.2

09 Jul 20:08
e7a95db
Compare
Choose a tag to compare

Adds strict mode and several Angular improvements including native animations, after studying and better understanding the Angular framework.

Fixes all points included in the feedback mail:

  • There are let _this = this; -> in Angular you don't have to take care of this scope.
  • setTimeout as debounce time -> this is a bad practise as there are better ways to do it (using rxjs for instance). Moreover, setTimeout is not the most performant solution.
  • He uses JQuery -> There is no point in using JQuery in an Angular project as the framework provides ways to manipulate the DOM (ViewChild) in a more elegant way. Apart from that, JQuery is a really intrusive way of manipulating the DOM. It also increases the bundle size of the app.
  • document.getElementById, document.querySelectorAll -> Bad practise in Angular ecosystem. This is an old school javascript style.
  • Inconsistent folder structure.
  • There are many variables without a type.
  • You need to click the button to perform the search instead of searching as you type.
  • I found a bug that makes the search button disappear forever (check the attached image below)

v1.1

23 Jun 11:46
0b2c9e4
Compare
Choose a tag to compare

Cache and visual improvements release