Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the FlightGear network protocol to v24 #1234

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

bcoconni
Copy link
Member

The FlightGear ticket 2313 has introduced a change in the FlightGear network protocol which broke backward compatibility with the then current version 24. That forced us to support a new version of the protocol via the commit b42f423. Unfortunately the support of the new protocol did not work well (see issue #325) and the code to support both protocol versions 24 and 25 was ugly.

It was later discovered that the new network protocol was also breaking the interface between Simulink and FlightGear (see FlightGear ticket 2742) so the decision has been made by the FlightGear developers to drop the protocol version 25 and revert it back to 24.

The network protocol version 25 has never been part of an official FlightGear release so reverting it back to 24 is not breaking backward compatibility.

This PR reverts the commit b42f423 since the support of the protocol version 25 is now meaningless. This should fix the issue #325 in the process.

Copy link

codecov bot commented Feb 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 141 lines in your changes missing coverage. Please review.

Project coverage is 24.78%. Comparing base (e6208a3) to head (3061255).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/input_output/FGOutputFG.cpp 0.00% 141 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1234      +/-   ##
==========================================
+ Coverage   24.76%   24.78%   +0.01%     
==========================================
  Files         170      170              
  Lines       19464    19450      -14     
==========================================
  Hits         4820     4820              
+ Misses      14644    14630      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bcoconni bcoconni merged commit 91ebed4 into JSBSim-Team:master Feb 28, 2025
29 checks passed
@bcoconni bcoconni deleted the bcoconni/issue325 branch February 28, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant