Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UE5 fix command console issue #1240

Merged
merged 6 commits into from
Feb 25, 2025
Merged

Conversation

gallonmate
Copy link
Contributor

@gallonmate gallonmate commented Feb 25, 2025

This update is to fix the errors discussed in issue: #1239 (comment)
-There was a syntax mistake in the regex with the - character and the [] characters were missing.
-Updated the error message to include the property name, for clarity.

Edit: I apologize any merging issues. It appears I did some syncing operations out of order and/or needed to rebase?

-Update target.cs to build with all UE5 versions
-Prevent editor crash with command console node if accidently using special characters
-Make GearDown editable in the level editor and fix bug with StartWithGearDown
-Edit the Blueprint & Animation Blueprint to stop errors when using Aircraft with less than two engines
This update is to fix the errors discussed in issue: JSBSim-Team#1239 (comment)
-There was a syntax mistake in the regex with the  ` - ` character and the `[]` characters were missing.
-Updated the error message to include the property name, for clarity.
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.79%. Comparing base (e871ef5) to head (ef99d32).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1240   +/-   ##
=======================================
  Coverage   24.79%   24.79%           
=======================================
  Files         169      169           
  Lines       19439    19439           
=======================================
  Hits         4819     4819           
  Misses      14620    14620           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bcoconni bcoconni merged commit c3ce012 into JSBSim-Team:master Feb 25, 2025
29 checks passed
@bcoconni
Copy link
Member

PR merged. Thanks for your help maintaining the UE plugin @gallonmate 👍 This is much appreciated.

I apologize any merging issues. It appears I did some syncing operations out of order and/or needed to rebase?

No problem. Rebasing is not mandatory as long as GitHub is telling that there are no conflicts between your branch and master. But generally speaking it's always a good habit to check that your local copy is up to date with the GitHub repo before starting coding a patch/fix 😉

@bcoconni bcoconni added the bug label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants