Put logger mutex behind a preprocessor flag #398
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logger mutex is not necessary on the platforms we support. Omitting it causes lots and lots of false positives when running tools like Helgrind. However, including it causes some extremely weird behavior when Helgrind runs, such as segfaults and hanging. I speculate that this behavior is due to the ODR violation that happens with the static logger mutex when JANA is linked incorrectly