LeptonID

[MarianaT27]

No description provided.

[c-dilks]

Either each one of these members needs to be documented, or you can use @doxygen_off and @doxygen_on to avoid having to write documentation here.

[c-dilks]

Don't forget to document this algorithm; see other algorithms for examples.

[c-dilks]

The header should only declare the variables, not define them; the definitions could go in the Start() method in Algorithm.cc.

[c-dilks]

Hi @MarianaT27, I got this up-to-date with respect to the main branch. The tests for this algorithm are still crashing, however:

===========================================================
There was a crash.
This is the entire stack trace of all threads:
===========================================================
#0  0x0000745461910887 in wait4 () from /usr/lib/libc.so.6
#1  0x00007454618609fb in ?? () from /usr/lib/libc.so.6
#2  0x000074546137bc48 in TUnixSystem::StackTrace() () from /home/dilks/builds/root/lib/libCore.so
#3  0x000074546137b584 in TUnixSystem::DispatchSignals(ESignals) () from /home/dilks/builds/root/lib/libCore.so
#4  <signal handler called>
#5  0x0000745460c6d958 in TMVA::Reader::EvaluateMVA(TString const&, double) () from /home/dilks/builds/root/lib/libTMVA.so
#6  0x0000745462a95450 in iguana::clas12::LeptonIDFilter::CalculateScore (this=0x5cf4b8a4a770, lepton_vars=...) at ../src/iguana/algorithms/clas12/LeptonIDFilter/Algorithm.cc:148
#7  0x0000745462a948b4 in operator()<hipo::bank, int> (__closure=0x5cf4b8a4be80, bank=<incomplete type>, row=0) at ../src/iguana/algorithms/clas12/LeptonIDFilter/Algorithm.cc:55
#8  0x0000745462a958ff in std::__invoke_impl<bool, iguana::clas12::LeptonIDFilter::Run(hipo::banklist&) const::<lambda(auto:28, auto:29)>&, hipo::bank&, int>(std::__invoke_other, struct {...} &) (__f=...) at /usr/include/c++/14.2.1/bits/invoke.h:61
#9  0x0000745462a95780 in std::__invoke_r<bool, iguana::clas12::LeptonIDFilter::Run(hipo::banklist&) const::<lambda(auto:28, auto:29)>&, hipo::bank&, int>(struct {...} &) (__fn=...) at /usr/include/c++/14.2.1/bits/invoke.h:114
#10 0x0000745462a95637 in std::_Function_handler<bool(hipo::bank&, int), iguana::clas12::LeptonIDFilter::Run(hipo::banklist&) const::<lambda(auto:28, auto:29)> >::_M_invoke(const std::_Any_data &, hipo::bank &, int &&) (__functor=..., __args#0=..., __args#1=
0x7ffe051ea014: 0) at /usr/include/c++/14.2.1/bits/std_function.h:290
#11 0x00007454632fd94f in hipo::bank::rowlist::filter(std::function<bool (hipo::bank&, int)>) () from /home/dilks/j/install/lib/pkgconfig/../../lib/libhipo4.so
#12 0x0000745462a94aa9 in iguana::clas12::LeptonIDFilter::Run (this=0x5cf4b8a4a770, banks=warning: Type size unknown, assuming 1. Try casting to a known type, or void *.
#13 0x0000745462a38555 in iguana::AlgorithmSequence::Run (this=0x7ffe051ea240, banks=warning: Type size unknown, assuming 1. Try casting to a known type, or void *.
#14 0x00005cf47e7a7eda in TestAlgorithm (command="algorithm", algo_name="clas12::LeptonIDFilter", prerequisite_algos=std::vector of length 0, capacity 0, bank_names=std::vector of length 2, capacity 2 = {...}, data_file="/home/dilks/j/iguana/data.hipo", num_events=10, verbose=true) at ../src/iguana/tests/include/TestAlgorithm.h:55
#15 0x00005cf47e7a0985 in main (argc=12, argv=0x7ffe051eb1a0) at ../src/iguana/tests/iguana_test.cc:225
===========================================================


The lines below might hint at the cause of the crash. If you see question
marks as part of the stack trace, try to recompile with debugging information
enabled and export CLING_DEBUG=1 environment variable before running.
You may get help by asking at the ROOT forum https://root.cern/forum
preferably using the command (.forum bug) in the ROOT prompt.
Only if you are really convinced it is a bug in ROOT then please submit a
report at https://root.cern/bugs or (preferably) using the command (.gh bug) in
the ROOT prompt. Please post the ENTIRE stack trace
from above as an attachment in addition to anything else
that might help us fixing this issue.
===========================================================
#5  0x0000745460c6d958 in TMVA::Reader::EvaluateMVA(TString const&, double) () from /home/dilks/builds/root/lib/libTMVA.so
#6  0x0000745462a95450 in iguana::clas12::LeptonIDFilter::CalculateScore (this=0x5cf4b8a4a770, lepton_vars=...) at ../src/iguana/algorithms/clas12/LeptonIDFilter/Algorithm.cc:148
#7  0x0000745462a948b4 in operator()<hipo::bank, int> (__closure=0x5cf4b8a4be80, bank=<incomplete type>, row=0) at ../src/iguana/algorithms/clas12/LeptonIDFilter/Algorithm.cc:55
#8  0x0000745462a958ff in std::__invoke_impl<bool, iguana::clas12::LeptonIDFilter::Run(hipo::banklist&) const::<lambda(auto:28, auto:29)>&, hipo::bank&, int>(std::__invoke_other, struct {...} &) (__f=...) at /usr/include/c++/14.2.1/bits/invoke.h:61
#9  0x0000745462a95780 in std::__invoke_r<bool, iguana::clas12::LeptonIDFilter::Run(hipo::banklist&) const::<lambda(auto:28, auto:29)>&, hipo::bank&, int>(struct {...} &) (__fn=...) at /usr/include/c++/14.2.1/bits/invoke.h:114
#10 0x0000745462a95637 in std::_Function_handler<bool(hipo::bank&, int), iguana::clas12::LeptonIDFilter::Run(hipo::banklist&) const::<lambda(auto:28, auto:29)> >::_M_invoke(const std::_Any_data &, hipo::bank &, int &&) (__functor=..., __args#0=..., __args#1=
0x7ffe051ea014: 0) at /usr/include/c++/14.2.1/bits/std_function.h:290
#11 0x00007454632fd94f in hipo::bank::rowlist::filter(std::function<bool (hipo::bank&, int)>) () from /home/dilks/j/install/lib/pkgconfig/../../lib/libhipo4.so
#12 0x0000745462a94aa9 in iguana::clas12::LeptonIDFilter::Run (this=0x5cf4b8a4a770, banks=warning: Type size unknown, assuming 1. Try casting to a known type, or void *.
#13 0x0000745462a38555 in iguana::AlgorithmSequence::Run (this=0x7ffe051ea240, banks=warning: Type size unknown, assuming 1. Try casting to a known type, or void *.
#14 0x00005cf47e7a7eda in TestAlgorithm (command="algorithm", algo_name="clas12::LeptonIDFilter", prerequisite_algos=std::vector of length 0, capacity 0, bank_names=std::vector of length 2, capacity 2 = {...}, data_file="/home/dilks/j/iguana/data.hipo", num_events=10, verbose=true) at ../src/iguana/tests/include/TestAlgorithm.h:55
#15 0x00005cf47e7a0985 in main (argc=12, argv=0x7ffe051eb1a0) at ../src/iguana/tests/iguana_test.cc:225
===========================================================

This was produced by running the following command from the build directory:

src/iguana/tests/iguana_test algorithm -n 10 -a clas12::LeptonIDFilter -f [HIPO_FILE] -b REC::Particle -b REC::Calorimeter -v

where [HIPO_FILE] should be replaced by some test HIPO file. (this test also runs on the CI)