feat: change Algorithm::GetBankIndex to a public method
#299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows users to get the index of a bank in a `hipo::banklist` using the name of the bank. Perhaps this feature could be upstreamed, but since `hipo::banklist` is just a type definition, I'm not sure where to put it exactly.
c-dilks
added a commit
that referenced
this pull request
Oct 25, 2024
- finding a bank is upstreamed: gavalian/hipo#65 - reverts #299
c-dilks
added a commit
that referenced
this pull request
Nov 19, 2024
- finding a bank is upstreamed: gavalian/hipo#65 - reverts #299
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows users to get the index of a bank in a
hipo::banklistusing the name of the bank. Perhaps this feature could be upstreamed, but sincehipo::banklistis just a type definition, I'm not sure where to put it exactly.