Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crisp migration #302

Merged
merged 2 commits into from
Jan 31, 2024
Merged

crisp migration #302

merged 2 commits into from
Jan 31, 2024

Conversation

formsdev
Copy link
Collaborator

@formsdev formsdev commented Jan 31, 2024

Summary by CodeRabbit

  • New Features
    • Enhanced chat functionality across various components and pages for a more integrated experience.
  • Refactor
    • Updated chat interactions to use a centralized useCrisp method for opening chats and sending messages, improving code maintainability and consistency.

@formsdev formsdev requested a review from JhumanJ January 31, 2024 13:26
Copy link
Contributor

coderabbitai bot commented Jan 31, 2024

Walkthrough

The recent changes across various components and pages in the client's codebase primarily focus on abstracting direct interactions with the $crisp object behind a new useCrisp() function. This function encapsulates methods for opening chats, showing helpdesk articles, and sending text messages, thereby standardizing the way Crisp chat functionalities are invoked across the application. This abstraction not only makes the code cleaner and more maintainable but also facilitates easier updates or changes to the Crisp integration in the future.

Changes

Files Summary
ProTag.vue, FormCleanings.vue, pricing.vue Modified to use useCrisp().openAndShowChat() instead of direct $crisp calls for chat functionality.
FormAboutSubmission.vue Changed to use crisp.openHelpdeskArticle(...) and refactored to include crisp: useCrisp() alongside storeToRefs(...).
CustomPlan.vue Updated to send a text message through useCrisp().sendTextMessage instead of using window.$crisp.
subscriptions/success.vue Added crisp property in data return object and changed $crisp.push to crisp.pushEvent in redirectIfSubscribed method.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between de3e2d6 and 1316e9a.
Files selected for processing (6)
  • client/components/global/ProTag.vue (1 hunks)
  • client/components/open/forms/components/form-components/FormAboutSubmission.vue (2 hunks)
  • client/components/pages/forms/show/FormCleanings.vue (1 hunks)
  • client/components/pages/pricing/CustomPlan.vue (1 hunks)
  • client/pages/pricing.vue (1 hunks)
  • client/pages/subscriptions/success.vue (2 hunks)
Files skipped from review due to trivial changes (1)
  • client/components/pages/forms/show/FormCleanings.vue
Additional comments: 7
client/components/pages/pricing/CustomPlan.vue (1)
  • 35-35: The change from direct window.$crisp usage to useCrisp().sendTextMessage for sending text messages in the customPlanClick method aligns with the PR's objective to centralize and standardize Crisp interactions. This is a positive change for maintainability and readability.
client/pages/subscriptions/success.vue (2)
  • 35-36: Adding crisp: useCrisp() to the setup return object is a good practice for centralizing Crisp interactions within the component. This ensures that all Crisp-related functionality is handled through a single, abstracted interface.
  • 62-62: Replacing this.$crisp.push with this.crisp.pushEvent in the redirectIfSubscribed method is consistent with the PR's goal of centralizing Crisp interactions. This change enhances code readability and maintainability.
client/components/global/ProTag.vue (1)
  • 80-80: The modification to use useCrisp().openAndShowChat() in the openChat method is in line with the PR's objective. This change simplifies the interaction with Crisp's API, making the code more maintainable and consistent across the application.
client/components/open/forms/components/form-components/FormAboutSubmission.vue (2)
  • 70-70: Replacing the direct $crisp.push call with crisp.openHelpdeskArticle for opening helpdesk articles is a significant improvement. It abstracts the direct interaction with Crisp, aligning with the PR's goal of centralizing Crisp interactions.
  • 145-146: The addition of crisp: useCrisp() in the setup function is a good practice, ensuring that Crisp interactions are centralized and managed through a single, abstracted interface within this component.
client/pages/pricing.vue (1)
  • 274-274: The update to the contactUs method to use useCrisp().openAndShowChat() instead of direct window.$crisp calls is consistent with the PR's objective of centralizing Crisp interactions. This enhances the maintainability and readability of the code.

@JhumanJ JhumanJ merged commit 5bdc76e into main Jan 31, 2024
4 checks passed
@JhumanJ JhumanJ deleted the crisp-migration branch January 31, 2024 16:48
JhumanJ added a commit that referenced this pull request Feb 1, 2024
Co-authored-by: Julien Nahum <julien@nahum.net>
JhumanJ added a commit that referenced this pull request Feb 1, 2024
Fix resize for all forms

crisp migration (#302)

Co-authored-by: Julien Nahum <julien@nahum.net>

fix console error (#304)

fix: dark mode issues on form preview (#301)

* fix: dark mode issues on form preview

* Fix darkmode issues

---------

Co-authored-by: Julien Nahum <julien@nahum.net>

Remove useless iframe attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants