-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crisp migration #302
crisp migration #302
Conversation
WalkthroughThe recent changes across various components and pages in the client's codebase primarily focus on abstracting direct interactions with the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (6)
- client/components/global/ProTag.vue (1 hunks)
- client/components/open/forms/components/form-components/FormAboutSubmission.vue (2 hunks)
- client/components/pages/forms/show/FormCleanings.vue (1 hunks)
- client/components/pages/pricing/CustomPlan.vue (1 hunks)
- client/pages/pricing.vue (1 hunks)
- client/pages/subscriptions/success.vue (2 hunks)
Files skipped from review due to trivial changes (1)
- client/components/pages/forms/show/FormCleanings.vue
Additional comments: 7
client/components/pages/pricing/CustomPlan.vue (1)
- 35-35: The change from direct
window.$crisp
usage touseCrisp().sendTextMessage
for sending text messages in thecustomPlanClick
method aligns with the PR's objective to centralize and standardize Crisp interactions. This is a positive change for maintainability and readability.client/pages/subscriptions/success.vue (2)
- 35-36: Adding
crisp: useCrisp()
to thesetup
return object is a good practice for centralizing Crisp interactions within the component. This ensures that all Crisp-related functionality is handled through a single, abstracted interface.- 62-62: Replacing
this.$crisp.push
withthis.crisp.pushEvent
in theredirectIfSubscribed
method is consistent with the PR's goal of centralizing Crisp interactions. This change enhances code readability and maintainability.client/components/global/ProTag.vue (1)
- 80-80: The modification to use
useCrisp().openAndShowChat()
in theopenChat
method is in line with the PR's objective. This change simplifies the interaction with Crisp's API, making the code more maintainable and consistent across the application.client/components/open/forms/components/form-components/FormAboutSubmission.vue (2)
- 70-70: Replacing the direct
$crisp.push
call withcrisp.openHelpdeskArticle
for opening helpdesk articles is a significant improvement. It abstracts the direct interaction with Crisp, aligning with the PR's goal of centralizing Crisp interactions.- 145-146: The addition of
crisp: useCrisp()
in thesetup
function is a good practice, ensuring that Crisp interactions are centralized and managed through a single, abstracted interface within this component.client/pages/pricing.vue (1)
- 274-274: The update to the
contactUs
method to useuseCrisp().openAndShowChat()
instead of directwindow.$crisp
calls is consistent with the PR's objective of centralizing Crisp interactions. This enhances the maintainability and readability of the code.
Co-authored-by: Julien Nahum <julien@nahum.net>
Fix resize for all forms crisp migration (#302) Co-authored-by: Julien Nahum <julien@nahum.net> fix console error (#304) fix: dark mode issues on form preview (#301) * fix: dark mode issues on form preview * Fix darkmode issues --------- Co-authored-by: Julien Nahum <julien@nahum.net> Remove useless iframe attributes
Summary by CodeRabbit
useCrisp
method for opening chats and sending messages, improving code maintainability and consistency.