Issue 295/docker images dont work

[donuk]

This patch de-activates sharp image processing on docker builds, bypassing issues using ipx/sharp in cross-platform builds.

Summary by CodeRabbit

• New Features
  • Introduced a new image provider to generate image URLs with optional modifiers.
  • Added support for a null image provider based on a configurable environment variable.
• Refactor
  • Improved how environment variables are handled in Docker containers for Nuxt.js applications.
• Chores
  • Updated Dockerfile to enhance the build process by including environment-specific configurations.

[coderabbitai]

Walkthrough

The update introduces a new image provider in a Nuxt.js application, controlled by an environment variable. It modifies the Docker build process to include a new .env file and adjusts the runtime configuration to support a conditional image provider setup. Additionally, it changes how environment variables are managed within the Docker container for the application, streamlining the process and enhancing flexibility in configuration.

Changes

File(s)	Change Summary
Dockerfile, client/.env.docker	Added steps to copy .env.docker to .env during build and introduced a new environment variable.
client/lib/null-image-provider.js	Added a function to generate image URLs with optional modifiers.
client/nuxt.config.ts	Added conditional image provider setup based on a runtime flag.
client/runtimeConfig.js	Added configuration for using the new image provider and updated SENTRY_TRACES_SAMPLE_RATE logic.
docker/nuxt-wrapper.sh	Modified environment variable loading and exporting strategy within Docker container.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between af277d8 and 796760e.

Files selected for processing (6)

• Dockerfile (1 hunks)
• client/.env.docker (1 hunks)
• client/lib/null-image-provider.js (1 hunks)
• client/nuxt.config.ts (1 hunks)
• client/runtimeConfig.js (1 hunks)
• docker/nuxt-wrapper.sh (1 hunks)

Additional comments: 5

client/lib/null-image-provider.js (1)

• 1-22: Ensure that useRuntimeConfig is safely used, especially in the context of server-side rendering, to avoid leaking sensitive information. Also, confirm that the external dependencies ufo and #image are properly managed and compatible with the project's setup.

client/runtimeConfig.js (2)

• 15-17: Confirm that the new useNullImageProvider configuration is correctly implemented and tested across the application to ensure it behaves as expected when the environment variable is set to yes.
• 18-18: Ensure that the updated logic for SENTRY_TRACES_SAMPLE_RATE and other Sentry-related configurations are correctly implemented and do not introduce any unintended side effects, especially in terms of error reporting and performance monitoring.

client/nuxt.config.ts (1)

• 67-78: Ensure that the conditional assignment within the image property is correctly implemented and tested. Verify that the null image provider is properly integrated and that the fallback to default image quality settings works as expected when the environment variable is not set to yes.

Dockerfile (1)

• 17-17: Confirm that the step to copy .env.docker to .env during the build process is correctly implemented and does not introduce any build or runtime issues. Ensure that the .env file is correctly used by the application within the Docker container.

[coderabbitai]

Using eval to export environment variables from the .env file poses a security risk if the .env file contains untrusted input. Consider using a safer method to parse and export environment variables.