fix email reply to issue

[madassdev]

Summary by CodeRabbit

• Bug Fixes
  • Improved email validation for the reply-to address in confirmation emails, ensuring fallback to a default email if the provided address is invalid.
• Tests
  • Added tests to verify confirmation emails are correctly sent with a valid reply-to address or fallback to the user's email if invalid.

[coderabbitai]

Walkthrough

The recent update introduces a validation mechanism for the replyTo email address in the submission confirmation mail functionality. If the provided replyTo email is not valid, the system now defaults to a predefined email address. Additionally, a new test ensures that a confirmation email is dispatched correctly even when the replyTo address is invalid, utilizing the user's email in such scenarios.

Changes

File(s)	Change Summary
app/Mail/.../SubmissionConfirmationMail.php	Updated getReplyToEmail to validate the replyTo email; defaults to a preset email if invalid.
tests/Feature/.../ConfirmationEmailTest.php	Added a test to verify confirmation emails with user's email when replyTo is invalid.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 7c90ed5 and 7ba6684.

Files selected for processing (2)

• app/Mail/Forms/SubmissionConfirmationMail.php (1 hunks)
• tests/Feature/Forms/ConfirmationEmailTest.php (1 hunks)

Additional comments: 2

app/Mail/Forms/SubmissionConfirmationMail.php (1)

• 66-69: The update to getReplyToEmail method introduces a validation check for the reply-to email address using filter_var with FILTER_VALIDATE_EMAIL. This is a good practice to ensure the email address is valid before using it. If the validation fails, it gracefully falls back to a default email address. This change effectively addresses the issue of handling invalid reply-to email addresses and enhances the robustness of the email sending functionality.

tests/Feature/Forms/ConfirmationEmailTest.php (1)

• 113-139: The addition of the test case it('does send a confirmation email even when reply to is broken', ...) is a valuable enhancement to the test suite. It verifies that the system defaults to using the user's email address as the reply-to address when an invalid reply-to address is provided. This test ensures that the changes made to handle invalid reply-to addresses are correctly implemented and function as expected. It's a good practice to include such tests to cover edge cases and maintain the reliability of the email functionality.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 7ba6684 and 6112d47.

Files ignored due to path filters (1)

• phpunit.xml is excluded by: !**/*.xml

Files selected for processing (1)

• tests/Feature/Forms/ConfirmationEmailTest.php (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• tests/Feature/Forms/ConfirmationEmailTest.php

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 6112d47 and 18008da.

Files selected for processing (1)

• tests/Feature/Forms/ConfirmationEmailTest.php (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• tests/Feature/Forms/ConfirmationEmailTest.php