fix local files in docker

[christianWilling]

Response::make doesn't exist anymore and the nginx.conf didnt allow the needed paths (/local/temp/, /forms/assets/)

Summary by CodeRabbit

• New Features
  • Enhanced server configuration to handle requests more efficiently for specific paths.
• Refactor
  • Improved the file serving functionality in the API for better code simplicity and readability.

[coderabbitai]

Walkthrough

The recent updates involve enhancements to the web server configuration and API routing. Specifically, two new location blocks were added to the Nginx configuration to better handle requests for specific paths by setting a variable and using the try_files directive. Additionally, in the API routing logic, the method for serving files has been streamlined by adopting response()->file() for a cleaner and more readable approach.

Changes

Files	Change Summary
docker/nginx.conf, routes/api.php	Added location blocks in Nginx config for specific paths, utilizing try_files. Updated file serving in API routing to use response()->file().

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 30587fb and 016adf3.

Files selected for processing (2)

• docker/nginx.conf (1 hunks)
• routes/api.php (1 hunks)

Additional comments: 3

docker/nginx.conf (2)

• 28-31: The addition of the location block for /local/temp/ is correctly configured to handle requests to this path. By setting $original_uri and using the try_files directive, it ensures that requests are properly directed, either serving the requested file or falling back to index.php with query parameters if needed. This setup is appropriate for serving temporary files while maintaining the flexibility to handle requests dynamically.
• 33-36: Similarly, the location block for /forms/assets/ is well-configured to handle requests to form-related assets. The configuration mirrors that of /local/temp/, ensuring consistency in handling file requests across different parts of the application. This addition improves the application's robustness by ensuring essential assets are accessible.

routes/api.php (1)

• 231-231: The update to use response()->file() for serving files is a positive change, aligning with modern Laravel practices. This method simplifies the response creation process and enhances readability. It's important to ensure that the Storage::path($path) and Storage::mimeType($path) calls are secure and do not expose the application to directory traversal attacks. Given the use of signed URLs, this risk is mitigated, but it's always good practice to validate or sanitize input paths as an additional layer of security.

[JhumanJ]

Thank you for your contribution!

[christianWilling]

i fixed the import so the test should pass now

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 016adf3 and aa0c231.

Files selected for processing (1)

• routes/api.php (2 hunks)

Files skipped from review as they are similar to previous changes (1)

• routes/api.php