Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: null message on input help #343

Merged
merged 2 commits into from
Mar 12, 2024
Merged

fix: null message on input help #343

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f46efdb
fix: null message on input help
madassdev Mar 12, 2024
1248c15
fix null message
madassdev Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/components/forms/components/InputHelp.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<template>
<div class="flex mb-1 input-help">
<small :class="theme.default.help" class="grow flex">
<slot name="help"><span class="field-help" v-html="help" /></slot>
<slot name="help"><span v-if="help" class="field-help" v-html="help" /></slot>
</small>
<slot name="after-help">
<small class="flex-grow" />
Comment on lines 1 to 7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [9-15]

The summary indicates the addition of a new computed property helpValue to handle null or undefined values for help. However, this computed property is missing from the provided script section. Adding this property is crucial for achieving the PR's objectives of improving user experience by handling null messages effectively.

Expand Down
Loading