Password not working when Notion embed - Fixed

[formsdev]

Summary by CodeRabbit

• Refactor
  • Updated cookie handling settings to enhance application security and compatibility across different browsers.

[coderabbitai]

Walkthrough

The change involves an update to the cookie handling configuration within the application, specifically adjusting the sameSite property of cookies. The modification is made in the Vue.js file responsible for a form page, where the sameSite setting is updated from false to 'none'. This adjustment affects how cookies are sent in relation to cross-site requests, enhancing compatibility and security in certain scenarios.

Changes

File	Change Summary
.../[slug]/index.vue	Updated sameSite property from false to 'none' in useCookie function.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between b41d6c0 and a763605.

Files selected for processing (1)

• client/pages/forms/[slug]/index.vue (1 hunks)

Additional comments: 2

client/pages/forms/[slug]/index.vue (2)

• 74-74: The update to the sameSite property from false to 'none' in the useCookie function call is appropriate for ensuring correct cookie handling in cross-site request scenarios, such as Notion embeds. This change aligns with modern browser security policies and is correctly paired with the secure property set to true.

However, it's important to thoroughly test this change across different browsers and environments to ensure consistent behavior and user experience.

• 74-74: While the client-side handling of passwords using sha256 and secure cookie attributes is implemented correctly, it's crucial to ensure that the server-side also employs robust security measures for password verification and storage. This includes using secure hashing algorithms with salts and ensuring secure communication channels.