Fix Checkbox logic rule

[chiragchhatrala]

@JhumanJ Can please test this on your local

Summary by CodeRabbit

• Bug Fixes
  • Improved form checkbox condition evaluation by switching to strict boolean checks, ensuring conditions are met only when the field value exactly matches the expected true/false state.

[coderabbitai]

Walkthrough

This update changes the evaluation logic in the checkbox condition check for both PHP and JavaScript implementations. The methods handling 'equals' and 'does_not_equal' in FormLogicConditionChecker now perform direct boolean comparisons instead of relying on a generic equality check. Specifically, the 'equals' operator returns true only if the value is false, while the 'does_not_equal' operator returns true only if the value is true. No modifications were made to the public API or exported entities.

Changes

File(s)	Change Summary
api/…/FormLogicConditionChecker.php client/…/FormLogicConditionChecker.js	Modified checkboxConditionMet to use strict boolean comparisons: for 'equals', return true if value is false, and for 'does_not_equal', return true if value is true, instead of using checkEquals.

Possibly related PRs

• fix date condition logic #510: Adjusts checkboxConditionChecker logic by changing boolean evaluation, similar to the modifications in this PR.
• fix checkbox input #582: Alters the handling of checkbox conditions by directly checking boolean values in the checkboxConditionMet method.

Suggested reviewers

• JhumanJ

Poem

I’m a rabbit coding on a sunny day,
Hoping logic leaps in a bouncy way.
Boolean checks now smartly rule the game,
'Equals' and 'does_not_equal' never look the same.
With keen eyes I celebrate this change,
Hoppy code and clear paths make my heart range!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 29640fc and 7d5f368.

📒 Files selected for processing (2)

• api/app/Service/Forms/FormLogicConditionChecker.php (1 hunks)
• client/lib/forms/FormLogicConditionChecker.js (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Build the Nuxt app

🔇 Additional comments (2)

client/lib/forms/FormLogicConditionChecker.js (1)

333-341: Verify the checkbox condition logic change.

The implementation has been changed to use direct boolean comparisons instead of value equality checks. This change assumes that checkbox values are strictly boolean, which might affect existing form data.

Run the following script to verify the usage of checkbox fields in the codebase:

✅ Verification successful

🏁 Script executed:

#!/bin/bash
# Description: Search for checkbox field definitions and their values
# to ensure they only use boolean values.

# Test: Search for checkbox field definitions
ast-grep --pattern 'type: "checkbox"'

# Test: Search for checkbox value assignments
rg -A 5 'checkbox.*value'

Length of output: 66788

---

Checkbox Condition Logic Verified
The search results confirm that checkbox fields in our forms are consistently treated as booleans. The condition checker (now implemented in api/app/Service/Forms/FormLogicConditionChecker.php) uses strict boolean comparisons—returning true only when a checkbox value exactly matches false (for 'equals') or true (for 'does_not_equal'). No evidence was found of checkbox fields being assigned non-boolean values.

api/app/Service/Forms/FormLogicConditionChecker.php (1)

363-373: LGTM! Changes align with the JavaScript implementation.

The PHP implementation correctly mirrors the JavaScript changes, ensuring consistent behavior across frontend and backend.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[JhumanJ]

Closed in favor of 0afe15f