feat: add PHPStan and automated tests to CI

.github/dependabot.yml

@@ -0,0 +1,12 @@
+# https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
+
+version: 2
+updates:
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "monthly"
+  - package-ecosystem: "composer"
+    directory: "/"
+    schedule:
+      interval: "monthly"

.github/workflows/tests.yml

@@ -0,0 +1,52 @@
+name: Automated tests
+
+on:
+  push:
+    branches: [ main ]
+  pull_request:
+    branches: [ main ]
+
+jobs:
+
+  tests:
+    # https://github.com/actions/virtual-environments
+    runs-on: ubuntu-22.04
+    defaults:
+      run:
+        working-directory: ./Extensions
+
+    steps:
+    - name: Git checkout source code
+      uses: actions/checkout@v4
+      with:
+        path: Extensions
+
+    # Composer tests
+
+    - name: Check PHP syntax
+      run: composer run-script php-lint
+
+    - name: Check PHTML syntax
+      run: composer run-script phtml-lint
+
+    - name: Use Composer cache
+      id: composer-cache
+      uses: actions/cache@v4
+      with:
+        path: Extensions/vendor
+        key: ${{ runner.os }}-php-${{ hashFiles('**/composer.lock') }}
+        restore-keys: |
+          ${{ runner.os }}-php-
+
+    - name: Run Composer install
+      run: composer install --prefer-dist --no-progress
+      if: steps.composer-cache.outputs.cache-hit != 'true'
+
+    - name: Git checkout FreshRSS source code
+      uses: actions/checkout@v4
+      with:
+        repository: FreshRSS/FreshRSS
+        path: FreshRSS
+
+    - name: PHPStan
+      run: composer run-script phpstan

Controllers/readeckButtonController.php

@@ -22,7 +22,7 @@ public function jsVarsAction(): void
       )
     ));
 
-    $this->view->_layout(false);
+    $this->view->_layout(null);
     $this->view->_path('readeckButton/vars.js');
 
     header('Content-Type: application/javascript; charset=utf-8');

composer.json

@@ -0,0 +1,55 @@
+{
+    "description": "Extension for FreshRSS",
+    "type": "project",
+    "require": {
+        "php": ">=8.1",
+        "ext-ctype": "*",
+        "ext-curl": "*",
+        "ext-dom": "*",
+        "ext-fileinfo": "*",
+        "ext-gmp": "*",
+        "ext-intl": "*",
+        "ext-json": "*",
+        "ext-libxml": "*",
+        "ext-mbstring": "*",
+        "ext-openssl": "*",
+        "ext-pcre": "*",
+        "ext-pdo": "*",
+        "ext-pdo_sqlite": "*",
+        "ext-session": "*",
+        "ext-simplexml": "*",
+        "ext-xml": "*",
+        "ext-xmlreader": "*",
+        "ext-zend-opcache": "*",
+        "ext-zip": "*",
+        "ext-zlib": "*"
+    },
+    "suggest": {
+        "ext-iconv": "*",
+        "ext-pdo_mysql": "*",
+        "ext-pdo_pgsql": "*"
+    },
+    "require-dev": {
+        "php": ">=8.1",
+        "ext-phar": "*",
+        "ext-tokenizer": "*",
+        "ext-xmlwriter": "*",
+        "phpstan/phpstan": "^1.11",
+        "phpstan/phpstan-strict-rules": "^1.6"
+    },
+    "scripts": {
+        "php-lint": "find . -type d -name 'vendor' -prune -o -name '*.php' -print0 | xargs -0 -n1 -P4 php -l 1>/dev/null",
+        "phtml-lint": "find . -type d -name 'vendor' -prune -o -name '*.phtml' -print0 | xargs -0 -n1 -P4 php -l 1>/dev/null",
+        "phpstan": "phpstan analyse --memory-limit 512M .",
+        "test": [
+            "@php-lint",
+            "@phtml-lint",
+            "@phpstan"
+        ]
+    },
+    "config": {
+        "allow-plugins": {
+            "phpstan/extension-installer": false
+        }
+    }
+}

docker-compose.yaml

@@ -2,12 +2,8 @@ services:
   freshrss:
     image: freshrss/freshrss:latest
     container_name: freshrss
-    restart: unless-stopped
-    logging:
-      options:
-        max-size: 10m
     volumes:
       - ./fresh_rss_data:/var/www/FreshRSS/data
-      - ./:/var/www/FreshRSS/extensions/freshrss-readeck-button
+      - ./:/var/www/FreshRSS/extensions/freshrss-readeck-button:ro
     ports:
       - 8080:80

phpstan.dist.neon

@@ -0,0 +1,44 @@
+parameters:
+	level: 6 # TODO: Increase to 9
+	fileExtensions:
+		- php
+		- phtml
+	paths:
+		- ../FreshRSS
+		- .
+	excludePaths:
+		analyse:
+			- ../FreshRSS
+			- vendor/
+			- fresh_rss_data/
+		analyseAndScan:
+			- .github/
+			- .vscode/
+			- .git/
+			- node_modules/
+	checkMissingOverrideMethodAttribute: true
+	reportMaybesInPropertyPhpDocTypes: false
+	treatPhpDocTypesAsCertain: false
+	strictRules:
+		allRules: false
+		booleansInConditions: true
+		closureUsesThis: true
+		disallowedConstructs: false
+		disallowedLooseComparison: false
+		matchingInheritedMethodNames: true
+		noVariableVariables: true
+		numericOperandsInArithmeticOperators: true
+		overwriteVariablesWithLoop: true
+		requireParentConstructorCall: true
+		strictCalls: true
+		switchConditionsMatchingType: true
+		uselessCast: true
+	exceptions:
+		check:
+			missingCheckedExceptionInThrows: false	# TODO pass
+			tooWideThrowType: true
+		implicitThrows: false
+		checkedExceptionClasses:
+			- 'Minz_Exception'
+includes:
+	- vendor/phpstan/phpstan-strict-rules/rules.neon