Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Bevy 0.15 #74

Merged
merged 11 commits into from
Dec 7, 2024
Merged

Update to Bevy 0.15 #74

merged 11 commits into from
Dec 7, 2024

Conversation

ptsd
Copy link
Contributor

@ptsd ptsd commented Nov 28, 2024

Hi, thanks for this super useful package 😄.

This is basically just deps and deprecation changes but I needed it so might as well save you the hassle 👍

Todo:

@ptsd ptsd force-pushed the bevy-0.15 branch 2 times, most recently from 46edd58 to d51cd71 Compare November 28, 2024 13:45
@Shatur
Copy link
Collaborator

Shatur commented Nov 28, 2024

Thank you :)

@onkoe
Copy link

onkoe commented Dec 4, 2024

By the way, if you're having trouble with an error that says something like this:

barrett@fedora ~/D/p/c/bevy_atmosphere (bevy-0.15)> cargo check
    Checking bevy_atmosphere v0.10.0 (/home/barrett/Documents/projects/contributions/bevy_atmosphere)
error[E0432]: unresolved import `bevy::image`
 --> src/pipeline.rs:8:5
  |
8 |     image::Image,
  |     ^^^^^ could not find `image` in `bevy`

error[E0432]: unresolved import `bevy::image`
 --> src/skybox.rs:4:5
  |
4 |     image::Image,
  |     ^^^^^ could not find `image` in `bevy`

error[E0433]: failed to resolve: could not find `image` in `bevy`
  --> src/skybox.rs:23:10
   |
23 | #[derive(AsBindGroup, TypePath, Debug, Clone, Asset)]
   |          ^^^^^^^^^^^ could not find `image` in `bevy`
   |
   = note: this error originates in the derive macro `AsBindGroup` (in Nightly builds, run with -Z macro-backtrace for more info)

(snip...)

It is being caused by this Bevy 0.15.0 bug: bevyengine/bevy#16563

As a workaround, you can enable any image-like feature in Bevy, including png:

[dependencies]
bevy = { version = "0.15.0", default-features = false, features = [
  "bevy_asset",
  "bevy_render",
  "bevy_pbr",
  # "png",
] }

Fix: Add `zero_initialize_workgroup_memory` to `ComputePipelineDescriptor` in `derive_atmospheric` macro.
Fix: Invalid `[]` accessor in trace `pipeline::prepare_atmosphere_resources`.
Add: Entry for `settings_trace` example with required features.
@ptsd ptsd marked this pull request as ready for review December 6, 2024 23:54
@Shatur Shatur merged commit cf36a87 into JonahPlusPlus:master Dec 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants