-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Bevy 0.15 #74
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46edd58
to
d51cd71
Compare
Thank you :) |
By the way, if you're having trouble with an error that says something like this: barrett@fedora ~/D/p/c/bevy_atmosphere (bevy-0.15)> cargo check
Checking bevy_atmosphere v0.10.0 (/home/barrett/Documents/projects/contributions/bevy_atmosphere)
error[E0432]: unresolved import `bevy::image`
--> src/pipeline.rs:8:5
|
8 | image::Image,
| ^^^^^ could not find `image` in `bevy`
error[E0432]: unresolved import `bevy::image`
--> src/skybox.rs:4:5
|
4 | image::Image,
| ^^^^^ could not find `image` in `bevy`
error[E0433]: failed to resolve: could not find `image` in `bevy`
--> src/skybox.rs:23:10
|
23 | #[derive(AsBindGroup, TypePath, Debug, Clone, Asset)]
| ^^^^^^^^^^^ could not find `image` in `bevy`
|
= note: this error originates in the derive macro `AsBindGroup` (in Nightly builds, run with -Z macro-backtrace for more info)
(snip...) It is being caused by this Bevy 0.15.0 bug: bevyengine/bevy#16563 As a workaround, you can enable any image-like feature in Bevy, including [dependencies]
bevy = { version = "0.15.0", default-features = false, features = [
"bevy_asset",
"bevy_render",
"bevy_pbr",
# "png",
] } |
Fix: Add `zero_initialize_workgroup_memory` to `ComputePipelineDescriptor` in `derive_atmospheric` macro. Fix: Invalid `[]` accessor in trace `pipeline::prepare_atmosphere_resources`. Add: Entry for `settings_trace` example with required features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for this super useful package 😄.
This is basically just deps and deprecation changes but I needed it so might as well save you the hassle 👍
Todo:
bevy_spectator
crates.io patch when upstream updates (see: Update to Bevy 0.15 bevy_spectator#14)