Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow changing the created skybox size when using detection. #76

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Allow changing the created skybox size when using detection. #76

merged 1 commit into from
Dec 12, 2024

Conversation

ptsd
Copy link
Contributor

@ptsd ptsd commented Dec 12, 2024

As per discussion in #75

@ptsd ptsd force-pushed the skybox-size-override branch from cd169d2 to f7545b3 Compare December 12, 2024 20:52
@ptsd ptsd marked this pull request as ready for review December 12, 2024 21:01
@Shatur Shatur merged commit 0f6bb31 into JonahPlusPlus:master Dec 12, 2024
3 checks passed
@Shatur
Copy link
Collaborator

Shatur commented Dec 12, 2024

Thanks! Would you like me to draft a new release?

@ptsd
Copy link
Contributor Author

ptsd commented Dec 12, 2024

Thanks! Would you like me to draft a new release?

Sounds good 👍. Technically a breaking change if using detection and inserting AtmosphereSettings without a ..default() but seems minor?

@Shatur
Copy link
Collaborator

Shatur commented Dec 12, 2024

I will tag it as 0.12.0 since it breaks the semver.

@ptsd
Copy link
Contributor Author

ptsd commented Dec 12, 2024

Also sorry missed something:

#77 😞

@Shatur Shatur mentioned this pull request Dec 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptsd @Shatur