Nullref

Juce-Assets · Mar 27, 2022 · 7fd5204 · 7fd5204
1 parent 3eb743e
commit 7fd5204
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 2 deletions.
diff --git a/Runtime/Ui/ViewStack/Instructions/HideInstruction.cs b/Runtime/Ui/ViewStack/Instructions/HideInstruction.cs
@@ -59,6 +59,7 @@ protected override async Task OnExecute(CancellationToken cancellationToken)
             {
                 UnityEngine.Debug.LogError($"Tried to Hide {nameof(entry.Id)} as Popup, " +
                     $"but it there was not a current view context, at {nameof(HideInstruction)}");
+                return;
             }
 
             if (entry.IsPopup)

diff --git a/Runtime/Ui/ViewStack/Instructions/MoveCurrentToForegroundInstruction.cs b/Runtime/Ui/ViewStack/Instructions/MoveCurrentToForegroundInstruction.cs
@@ -32,6 +32,7 @@ protected override void OnInstantExecute()
             {
                 UnityEngine.Debug.LogError($"Tried to MoveCurrentToForeground " +
                     $"but it there was not a current view context, at {nameof(MoveCurrentToForegroundInstruction)}");
+                return;
             }
 
             bool found = entriesRepository.TryGet(context.ViewId, out IViewStackEntry entry);

diff --git a/Runtime/Ui/ViewStack/Instructions/SetInteractableInstruction.cs b/Runtime/Ui/ViewStack/Instructions/SetInteractableInstruction.cs
@@ -34,7 +34,6 @@ protected override void OnInstantExecute()
             {
                 UnityEngine.Debug.LogError($"Tried to SetInteractable {nameof(IViewStackEntry)} of type {entryId}, " +
                     $"but it was not registered, at {nameof(SetInteractableInstruction)}");
-
                 return;
             }
 

diff --git a/Runtime/Ui/ViewStack/Instructions/ShowInstruction.cs b/Runtime/Ui/ViewStack/Instructions/ShowInstruction.cs
@@ -40,7 +40,6 @@ protected async override Task OnExecute(CancellationToken cancellationToken)
             {
                 UnityEngine.Debug.LogError($"Tried to Show {nameof(IViewStackEntry)} of type {entryId}, " +
                     $"but it was not registered, at {nameof(ShowInstruction)}");
-
                 return;
             }
-Original file line number
+Diff line change
@@ Expand Up @@
                 {
                     UnityEngine.Debug.LogError($"Tried to Hide {nameof(entry.Id)} as Popup, " +
                         $"but it there was not a current view context, at {nameof(HideInstruction)}");
+                    return;
                 }
                 if (entry.IsPopup)
@@ Expand Down @@