Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new EPinType.Goal #19

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

AuNedelec
Copy link
Contributor

@AuNedelec AuNedelec commented Jun 26, 2024

Including marker image, default photo and test example. The default photo still needs to be manually set in /places.ts. Working on it, with a bit of time, maybe I can make it working without crying out for help.

PLEASE CHECK THIS CURRENT EXPERIMENT THOROUGHLY, MAYBE I BROKE EVERYTHING.

… example. The defaukt photo still needs to be manually set in places.ts. Working on it.
Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
takeyouthere ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 10:24am

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What an amazing illustration! Love it!

@JuditKaramazov JuditKaramazov added the enhancement New feature or request label Jun 26, 2024
@JuditKaramazov JuditKaramazov linked an issue Jun 26, 2024 that may be closed by this pull request
5 tasks
Copy link
Owner

@JuditKaramazov JuditKaramazov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The illustrations are gorgeous, and the integration is well-aligned with the site's behavior. Great job!

As for the suggested solutions we proposed in the last issue:

  • You designed a new EPin image.
  • You created a new EPinType accordingly.
  • The template image is una auténtica preciosidad.

Congratulations - and well done! I am genuinely proud of your progress and talent 🚀

@JuditKaramazov JuditKaramazov merged commit a2c71fa into JuditKaramazov:main Jun 26, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: New EPin type (wishlist/goals)
2 participants