Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new functionality from KA 0.9.32 #2627

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

vchuravy
Copy link
Member

Particularly:

  • pagelock! == pin
  • multi-GPU

Copy link
Contributor

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/CUDAKernels.jl b/src/CUDAKernels.jl
index 28f29b92f..de954caa0 100644
--- a/src/CUDAKernels.jl
+++ b/src/CUDAKernels.jl
@@ -56,11 +56,11 @@ function KA.ndevices(::CUDABackend)
 end
 
 function KA.device(::CUDABackend)
-    deviceid(state.device)+1
+    return deviceid(state.device) + 1
 end
 
 function KA.device!(::CUDABackend, id)
-    device!(id-1)
+    return device!(id - 1)
 end
 
 ## kernel launch

@maleadt
Copy link
Member

maleadt commented Jan 23, 2025

So you're going with integer device IDs? Not sure that's the most portable decision...

Anyhow, CI failures related.

@maleadt maleadt marked this pull request as draft February 4, 2025 10:41
@maleadt maleadt added enhancement New feature or request dependencies About things we use. labels Feb 4, 2025
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies About things we use. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants