-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MinDistanceSampling
for 3D Ball
#1121
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ometry/Meshes.jl into mindistancesampling-ball
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1121 +/- ##
=======================================
Coverage 87.70% 87.70%
=======================================
Files 191 191
Lines 5984 5986 +2
=======================================
+ Hits 5248 5250 +2
Misses 736 736 ☔ View full report in Codecov by Sentry. |
Would you mind creating a new release, @juliohm? |
Will do in a few seconds 👍🏽 Finishing up another PR with the |
Currently,
MinDistanceSampling
for a 3D Ball is not supported. To support it, there are two different options: 1. Properly supportRegularDiscretization
for a 3D Ball by addingPyramid
elements in the center similarly as in here and then use the fallback or 2. add a specialized method forBall
. This PR follows the second approach as it is quite straightforward to add, but allowing support forRegularDiscretization
of a 3D Ball would still be nice (s.t.discretize(ball::Ball{𝔼{3})
could use that).TODO: