Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MinDistanceSampling for 3D Ball #1121

Merged
merged 6 commits into from
Oct 25, 2024
Merged

Conversation

JoshuaLampert
Copy link
Member

@JoshuaLampert JoshuaLampert commented Oct 25, 2024

Currently, MinDistanceSampling for a 3D Ball is not supported. To support it, there are two different options: 1. Properly support RegularDiscretization for a 3D Ball by adding Pyramid elements in the center similarly as in here and then use the fallback or 2. add a specialized method for Ball. This PR follows the second approach as it is quite straightforward to add, but allowing support for RegularDiscretization of a 3D Ball would still be nice (s.t. discretize(ball::Ball{𝔼{3}) could use that).

TODO:

  • Add test

JoshuaLampert and others added 3 commits October 25, 2024 19:15
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.70%. Comparing base (e00e8b2) to head (7764ce9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1121   +/-   ##
=======================================
  Coverage   87.70%   87.70%           
=======================================
  Files         191      191           
  Lines        5984     5986    +2     
=======================================
+ Hits         5248     5250    +2     
  Misses        736      736           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliohm juliohm merged commit 079c4fc into master Oct 25, 2024
16 checks passed
@juliohm juliohm deleted the mindistancesampling-ball branch October 25, 2024 19:19
@JoshuaLampert
Copy link
Member Author

Would you mind creating a new release, @juliohm?

@juliohm
Copy link
Member

juliohm commented Oct 25, 2024

Will do in a few seconds 👍🏽 Finishing up another PR with the getindex for topology as we discussed on Zulip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants