Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement indexable api for topology #1122

Merged
merged 4 commits into from
Oct 25, 2024
Merged

Implement indexable api for topology #1122

merged 4 commits into from
Oct 25, 2024

Conversation

juliohm
Copy link
Member

@juliohm juliohm commented Oct 25, 2024

As discussed on Zulip

@juliohm juliohm requested a review from JoshuaLampert October 25, 2024 19:48
Copy link
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I have only two minor suggestions.

src/topologies.jl Outdated Show resolved Hide resolved
src/topologies.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.68%. Comparing base (079c4fc) to head (34e1b6c).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/topologies.jl 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1122      +/-   ##
==========================================
- Coverage   87.70%   87.68%   -0.02%     
==========================================
  Files         191      191              
  Lines        5986     5994       +8     
==========================================
+ Hits         5250     5256       +6     
- Misses        736      738       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

juliohm and others added 2 commits October 25, 2024 17:00
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
@juliohm
Copy link
Member Author

juliohm commented Oct 25, 2024

I've also implemented the suggested optimizations for Domain for consistency. Waiting for tests before merging and releasing a patch.

@JoshuaLampert
Copy link
Member

Thanks!

@juliohm juliohm merged commit f9d473e into master Oct 25, 2024
14 of 16 checks passed
@juliohm juliohm deleted the indexable-topology branch October 25, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants