-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement indexable api for topology #1122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I have only two minor suggestions.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1122 +/- ##
==========================================
- Coverage 87.70% 87.68% -0.02%
==========================================
Files 191 191
Lines 5986 5994 +8
==========================================
+ Hits 5250 5256 +6
- Misses 736 738 +2 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
I've also implemented the suggested optimizations for Domain for consistency. Waiting for tests before merging and releasing a patch. |
Thanks! |
As discussed on Zulip